From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx194.postini.com [74.125.245.194]) by kanga.kvack.org (Postfix) with SMTP id 526F36B0044 for ; Thu, 29 Mar 2012 04:40:20 -0400 (EDT) From: Naoya Horiguchi Subject: [PATCH] pagemap: remove remaining unneeded spin_lock() Date: Thu, 29 Mar 2012 04:39:39 -0400 Message-Id: <1333010379-31126-1-git-send-email-n-horiguchi@ah.jp.nec.com> Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Sasha Levin , Andrea Arcangeli , Hugh Dickins , Naoya Horiguchi , linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org commit: 025c5b2451e4 "thp: optimize away unnecessary page table locking" moves spin_lock() into pmd_trans_huge_lock() in order to avoid locking unless pmd is for thp. So this spin_lock() is a bug. Reported-by: Sasha Levin Signed-off-by: Naoya Horiguchi Cc: stable@vger.kernel.org --- fs/proc/task_mmu.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git linux-3.3.0-6658a6991ce.orig/fs/proc/task_mmu.c linux-3.3.0-6658a6991ce/fs/proc/task_mmu.c index 9694cc2..06d2b70 100644 --- linux-3.3.0-6658a6991ce.orig/fs/proc/task_mmu.c +++ linux-3.3.0-6658a6991ce/fs/proc/task_mmu.c @@ -786,7 +786,6 @@ static int pagemap_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end, /* find the first VMA at or above 'addr' */ vma = find_vma(walk->mm, addr); - spin_lock(&walk->mm->page_table_lock); if (pmd_trans_huge_lock(pmd, vma) == 1) { for (; addr != end; addr += PAGE_SIZE) { unsigned long offset; -- 1.7.7.6 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org