From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3989DC3DA4A for ; Fri, 9 Aug 2024 15:29:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2EC56B0095; Fri, 9 Aug 2024 11:29:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DDFE6B0098; Fri, 9 Aug 2024 11:29:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A58A6B009A; Fri, 9 Aug 2024 11:29:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6F4D16B0095 for ; Fri, 9 Aug 2024 11:29:51 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EE4764122A for ; Fri, 9 Aug 2024 15:29:50 +0000 (UTC) X-FDA: 82433092140.06.F1FC55C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id AE40F40014 for ; Fri, 9 Aug 2024 15:29:48 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gRpfxXnV; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723217355; a=rsa-sha256; cv=none; b=wvDYECAYVFujcL3GpHSjdABeYrfp5e1JHVjPfSDUF2MBdqOjmwB4bAVpBEBamDRlfxFgy0 jml1H3aJe1Fr3IrNb7Weig+J/pnKpLtO5KEuRQo2vlkkHp0VWszh1b5hT7IAL7y+3XnHgN +hODtJdytw52eT9hGyG3f6uqvkAbpcs= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gRpfxXnV; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723217355; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+qb0Tn3R4/F9P9guJ4b8TeJDGiJ6K5JkcxwGHngJl1Y=; b=juoja0J9SnV9UuHwwUbock8EqkoMKuFSHfTBINKS+92AnC4IOsb0t8TWQXbCUebZfkJ1Ro e4IIBryK19Ec4uhzOzCjfvJ6aHOTgCIyZ7n8qe3vVPOkbp2z0nNw/TPmqL51q8PQVlQ15K i4eDcibLM34DwJkthSFsOkoRXcRnVr0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723217388; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+qb0Tn3R4/F9P9guJ4b8TeJDGiJ6K5JkcxwGHngJl1Y=; b=gRpfxXnVFXiDntKny7UcAiQBBuxJe2nUL4FKqBPnX4pl1JoUkmYcwrNxgjnh8qYzRfKBaf aPxg0rCzWJOomNoJZTP6UF3BlVUcabWoZQcrmBHdPbZSmjiaKpq8RJpMzmhNUK79TBvny6 vNXjm62GBAr84D5tib0Q6i861AzRNsc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-596-M6cJWmSPP7mVBJupnywocg-1; Fri, 09 Aug 2024 11:29:46 -0400 X-MC-Unique: M6cJWmSPP7mVBJupnywocg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-42807a05413so14866155e9.2 for ; Fri, 09 Aug 2024 08:29:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723217385; x=1723822185; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=+qb0Tn3R4/F9P9guJ4b8TeJDGiJ6K5JkcxwGHngJl1Y=; b=wuitpWzBW4/GtcAJek/aee/q9oYu72mWhNm4dSbbZ4xPxU+G67FACzhwLmmWLSH0A7 WeIJQ0rnmAZMF2JTtVcsuoyndbEcMIBfeet4bFVxfQUO8sVayvwoL6+/aMRl9adKvYiK NMqUop6trVYbGveez/KbH/I9Dg1Qa+B++2QhSh5HQR4n41pSrLqHGPnFOzxIUhoB9nKp HsAHzL9GqEtRqXaLY48EG8q/WjPYa0fvaz0C5JxTl99Xks5rMVgcpjkkbVkdiQFfXDD2 bkM9Qr38wptYDCX0YlNxPGd0Syx5fTCesunxWgR5D784ek/kDHyrDiu4Cwksw0EyMWop vU8A== X-Forwarded-Encrypted: i=1; AJvYcCVJzrKNLAavhfbNKeOBTREbH7fC4uXHQ7tLjn1P/vBikRC2uPVigZkWRPFS6cbPDspivNVWBJefEHHZAoT4+z+RC4s= X-Gm-Message-State: AOJu0YzZJeGr7prcSlsE9+uug2hcDIC0+/oLerEypU6ynFSmfcwbGs96 KF4T+Wl0f3te8JMlAz1w2pcEEVeYjCWhQG4OJHZkVe5VNDeMlvv/qtNMQDMg9s6GVwBMMEM5ae/ BkC3xjWq3qKlYs3d/osKP4VG9AvrO5cIojSrWE5mmrCIrtg+W X-Received: by 2002:a05:600c:3588:b0:426:647b:1bfa with SMTP id 5b1f17b1804b1-429c3a174c2mr14386915e9.8.1723217385233; Fri, 09 Aug 2024 08:29:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGKTiQa7A0hgIVpw/ZWs2EQKjIeTX5+pvF0wUqZq/lUQ9GaeOmQ8UyiigVuIJHlsZzHtD3kPw== X-Received: by 2002:a05:600c:3588:b0:426:647b:1bfa with SMTP id 5b1f17b1804b1-429c3a174c2mr14386615e9.8.1723217384686; Fri, 09 Aug 2024 08:29:44 -0700 (PDT) Received: from ?IPV6:2003:d8:2f09:3f00:d228:bd67:7baa:d604? (p200300d82f093f00d228bd677baad604.dip0.t-ipconnect.de. [2003:d8:2f09:3f00:d228:bd67:7baa:d604]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429059e0082sm133666195e9.48.2024.08.09.08.29.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Aug 2024 08:29:44 -0700 (PDT) Message-ID: <13318f5e-6a76-49ca-8c7a-9f461061d1d7@redhat.com> Date: Fri, 9 Aug 2024 17:29:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] mm/numa: no task_numa_fault() call if PMD is changed To: Zi Yan , linux-mm@kvack.org Cc: Andrew Morton , "Huang, Ying" , Baolin Wang , Kefeng Wang , Yang Shi , Mel Gorman , linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20240809145906.1513458-1-ziy@nvidia.com> <20240809145906.1513458-3-ziy@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240809145906.1513458-3-ziy@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 164uxkffat6kjahdbcss3gpx644u6m1t X-Rspamd-Queue-Id: AE40F40014 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1723217388-993324 X-HE-Meta: U2FsdGVkX1/AiI+t5RS2U0V/vg5mL0kTcvYKKWa/xQYKQDlZioT3LRjr3jrh9WJ3SR7HCMN44PpjqddkC7TrJWrI8Aq6xrLap1afN2NWX8ZBhGVu+HJh8kCa1zgLyt/1yZzBZNEjlqt+QiPbwbGtn84eY2LluqJL1TrH6Iic8a/tK/ZkbChJfERbka6IIzxBvhIQ7Nc5Iq+FKuCBIBTkaTtH1+z6g/QUDVXU3aR9navuUF0dbAXX+lZA4cMRj8qn4YOS7Sehe7YgIa1lXNAgYHGeIpjGLumQ/rRMSMnnHU2YtmH8qPYZChNgUVVECV9aUQ0fJasDvoDfH8y6uAgNtRgAO/qWlQVpIDP83Q7wPEa6dB6E4llvpCYBT9IlOK4yR0KNAOwh1yK9UoDdZTxw5vlfE1aE42W85NGTR6VMP9ZmZ7/tRLRLXsBi2yQawocxbQTBFj2KU1/I5zzO/4zHkLYcbmVpXxP/j1t0ScWRDIQb8BP4tct6sPpD4HDRFSdtwSCiWjJxN8ca6egQEP7Jk8Q4iz6+qWMaNouCWiq1rVqopnFBQUocYGDe7lnb1q8/KWeHS66qs0pHmeo9GeTjazhcxZ/KqQHV5jJ2XMq8XGhLKJLXU3393zx0snLimRk37CQDkx2zR5QRflP/9Zk3AcPLwbKWTrN6wkr4duRAnvgIEyFxJei7oCXKKRixLm++dgIsZFVU8/02hGIDIfLJhRWZMs+5sg0LDhUf3LjppSUmJ0F1JMsxOkRSIgkc9eawK17D/Cyzm16jp19b4FdNNJ5pv9jagOm/pLeffElUqmmdpNqFqx4Qxn9jyvtyGFevqk82FZjiQgYzNzS8UaHqG0CrWUYVPi7PFnppmVM4UGjt5C6BbdYzl0nvh6IeLa9kBglhEK+3Fh0zyGquKqoIP5lKIk6c87kDqt9veb3eCjcZa03kMBv5gfeMZ+6SWX4aJe0AltyOcr3qgyCuk3k lhyNpgx1 gx0mVLZ7tTbLOT2O8HwN1uoXilBDLu3yHqGUg3G65XJW9tvPK7vsP+h3h3pVBSTBGCDRqDufmTVBc/h7JsGFGk1dlc/tf6OF7OP2j6DpsQLfj968fxvzhVakbuPTV2iRNjoH/e4P9BE0zL5VMQ75QQhbivrnvJ8zHZdX3BqxubEIx9olJejIwmJkdJ2fKyyzyxzch6WD8eDFjxATvUkbT/CQY5+CJHMJ8v9tTW8VTX/JykJ+LoS6O3GnLLJKdMOR+IxjFAnGZqHrQWxukUebKzIUdcTQNdKm9lTK3/OwcI0X5igphtJIATv978QtlOSovPWubXk13NtdLU8KuaqFyA1m6syGjLHxg+arCWSoeHkAwM5jlsB8b+j1C37dE9v0T9boiYvGAB3S3aLFDsuDwHJsNbtIRdIaV+OOrHkCG4W3Ba0SGx5179baZMBeXCChbnwF0dxr6VHNzL/iO6UoajMzqGc0wJ4eEE2Cg1mWxpNrXWDjf6LF+zERIGbndgCBTPOLKOH+JJ7kTKYZaiVuDISnyu2q10fYjviYM4vC1G378Xh8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.08.24 16:59, Zi Yan wrote: > When handling a numa page fault, task_numa_fault() should be called by a > process that restores the page table of the faulted folio to avoid > duplicated stats counting. Commit c5b5a3dd2c1f ("mm: thp: refactor NUMA > fault handling") restructured do_huge_pmd_numa_page() and did not avoid > task_numa_fault() call in the second page table check after a numa > migration failure. Fix it by making all !pmd_same() return immediately. > > This issue can cause task_numa_fault() being called more than necessary > and lead to unexpected numa balancing results (It is hard to tell whether > the issue will cause positive or negative performance impact due to > duplicated numa fault counting). > > Reported-by: "Huang, Ying" > Closes: https://lore.kernel.org/linux-mm/87zfqfw0yw.fsf@yhuang6-desk2.ccr.corp.intel.com/ > Fixes: c5b5a3dd2c1f ("mm: thp: refactor NUMA fault handling") > Cc: > Signed-off-by: Zi Yan > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb