From: Sha Zhengju <handai.szj@gmail.com>
To: linux-mm@kvack.org, cgroups@vger.kernel.org
Cc: kamezawa.hiroyu@jp.fujitsu.com, kirill@shutemov.name,
Sha Zhengju <handai.szj@taobao.com>
Subject: [PATCH] memcg: revise the position of threshold index while unregistering event
Date: Tue, 6 Mar 2012 20:12:23 +0800 [thread overview]
Message-ID: <1331035943-7456-1-git-send-email-handai.szj@taobao.com> (raw)
From: Sha Zhengju <handai.szj@taobao.com>
Index current_threshold should point to threshold just below or equal to usage.
See below:
http://www.spinics.net/lists/cgroups/msg00844.html
Signed-off-by: Sha Zhengju <handai.szj@taobao.com>
---
mm/memcontrol.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 22d94f5..cd40d67 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -4398,7 +4398,7 @@ static void mem_cgroup_usage_unregister_event(struct cgroup *cgrp,
continue;
new->entries[j] = thresholds->primary->entries[i];
- if (new->entries[j].threshold < usage) {
+ if (new->entries[j].threshold <= usage) {
/*
* new->current_threshold will not be used
* until rcu_assign_pointer(), so it's safe to increment
--
1.7.4.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2012-03-06 12:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 12:12 Sha Zhengju [this message]
2012-03-07 23:13 ` Kirill A. Shutemov
2012-03-08 5:44 ` KAMEZAWA Hiroyuki
2012-03-08 7:02 ` Sha Zhengju
2012-03-08 7:30 ` KAMEZAWA Hiroyuki
2012-03-08 9:37 ` Sha Zhengju
2012-04-05 23:35 ` Andrew Morton
2012-04-05 23:37 ` Andrew Morton
2012-04-06 3:59 ` Sha Zhengju
2012-04-06 4:04 ` [RESEND, PATCH] memcg: make threshold index in the right position Sha Zhengju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331035943-7456-1-git-send-email-handai.szj@taobao.com \
--to=handai.szj@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=handai.szj@taobao.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kirill@shutemov.name \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox