From: Marek Szyprowski <m.szyprowski@samsung.com>
To: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-mm@kvack.org,
linaro-mm-sig@lists.linaro.org
Cc: Michal Nazarewicz <mina86@mina86.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Daniel Walker <dwalker@codeaurora.org>,
Mel Gorman <mel@csn.ul.ie>, Arnd Bergmann <arnd@arndb.de>,
Jesse Barker <jesse.barker@linaro.org>,
Jonathan Corbet <corbet@lwn.net>,
Shariq Hasnain <shariq.hasnain@linaro.org>,
Chunsang Jeong <chunsang.jeong@linaro.org>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Rob Clark <rob.clark@linaro.org>,
Ohad Ben-Cohen <ohad@wizery.com>
Subject: [PATCHv21 16/16] ARM: Samsung: use CMA for 2 memory banks for s5p-mfc device
Date: Fri, 10 Feb 2012 18:32:31 +0100 [thread overview]
Message-ID: <1328895151-5196-17-git-send-email-m.szyprowski@samsung.com> (raw)
In-Reply-To: <1328895151-5196-1-git-send-email-m.szyprowski@samsung.com>
Replace custom memory bank initialization using memblock_reserve and
dma_declare_coherent with a single call to CMA's dma_declare_contiguous.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm/plat-s5p/dev-mfc.c | 51 ++++++-------------------------------------
1 files changed, 7 insertions(+), 44 deletions(-)
diff --git a/arch/arm/plat-s5p/dev-mfc.c b/arch/arm/plat-s5p/dev-mfc.c
index a30d36b..fcb8400 100644
--- a/arch/arm/plat-s5p/dev-mfc.c
+++ b/arch/arm/plat-s5p/dev-mfc.c
@@ -14,6 +14,7 @@
#include <linux/interrupt.h>
#include <linux/platform_device.h>
#include <linux/dma-mapping.h>
+#include <linux/dma-contiguous.h>
#include <linux/memblock.h>
#include <linux/ioport.h>
@@ -22,52 +23,14 @@
#include <plat/irqs.h>
#include <plat/mfc.h>
-struct s5p_mfc_reserved_mem {
- phys_addr_t base;
- unsigned long size;
- struct device *dev;
-};
-
-static struct s5p_mfc_reserved_mem s5p_mfc_mem[2] __initdata;
-
void __init s5p_mfc_reserve_mem(phys_addr_t rbase, unsigned int rsize,
phys_addr_t lbase, unsigned int lsize)
{
- int i;
-
- s5p_mfc_mem[0].dev = &s5p_device_mfc_r.dev;
- s5p_mfc_mem[0].base = rbase;
- s5p_mfc_mem[0].size = rsize;
-
- s5p_mfc_mem[1].dev = &s5p_device_mfc_l.dev;
- s5p_mfc_mem[1].base = lbase;
- s5p_mfc_mem[1].size = lsize;
-
- for (i = 0; i < ARRAY_SIZE(s5p_mfc_mem); i++) {
- struct s5p_mfc_reserved_mem *area = &s5p_mfc_mem[i];
- if (memblock_remove(area->base, area->size)) {
- printk(KERN_ERR "Failed to reserve memory for MFC device (%ld bytes at 0x%08lx)\n",
- area->size, (unsigned long) area->base);
- area->base = 0;
- }
- }
-}
-
-static int __init s5p_mfc_memory_init(void)
-{
- int i;
-
- for (i = 0; i < ARRAY_SIZE(s5p_mfc_mem); i++) {
- struct s5p_mfc_reserved_mem *area = &s5p_mfc_mem[i];
- if (!area->base)
- continue;
+ if (dma_declare_contiguous(&s5p_device_mfc_r.dev, rsize, rbase, 0))
+ printk(KERN_ERR "Failed to reserve memory for MFC device (%u bytes at 0x%08lx)\n",
+ rsize, (unsigned long) rbase);
- if (dma_declare_coherent_memory(area->dev, area->base,
- area->base, area->size,
- DMA_MEMORY_MAP | DMA_MEMORY_EXCLUSIVE) == 0)
- printk(KERN_ERR "Failed to declare coherent memory for MFC device (%ld bytes at 0x%08lx)\n",
- area->size, (unsigned long) area->base);
- }
- return 0;
+ if (dma_declare_contiguous(&s5p_device_mfc_l.dev, lsize, lbase, 0))
+ printk(KERN_ERR "Failed to reserve memory for MFC device (%u bytes at 0x%08lx)\n",
+ rsize, (unsigned long) rbase);
}
-device_initcall(s5p_mfc_memory_init);
--
1.7.1.569.g6f426
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-02-10 17:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 17:32 [PATCHv21 00/16] Contiguous Memory Allocator Marek Szyprowski
2012-02-10 17:32 ` [PATCHv21 01/16] mm: page_alloc: remove trailing whitespace Marek Szyprowski
2012-02-10 17:32 ` [PATCHv21 02/16] mm: compaction: introduce isolate_migratepages_range() Marek Szyprowski
2012-02-14 7:19 ` KAMEZAWA Hiroyuki
2012-02-10 17:32 ` [PATCHv21 03/16] mm: compaction: introduce map_pages() Marek Szyprowski
2012-02-14 7:25 ` KAMEZAWA Hiroyuki
2012-02-10 17:32 ` [PATCHv21 04/16] mm: compaction: introduce isolate_freepages_range() Marek Szyprowski
2012-02-14 7:30 ` KAMEZAWA Hiroyuki
2012-02-10 17:32 ` [PATCHv21 05/16] mm: compaction: export some of the functions Marek Szyprowski
2012-02-14 7:47 ` KAMEZAWA Hiroyuki
2012-02-10 17:32 ` [PATCHv21 06/16] mm: page_alloc: introduce alloc_contig_range() Marek Szyprowski
2012-02-14 7:54 ` KAMEZAWA Hiroyuki
2012-02-10 17:32 ` [PATCHv21 07/16] mm: page_alloc: change fallbacks array handling Marek Szyprowski
2012-02-14 7:56 ` KAMEZAWA Hiroyuki
2012-02-10 17:32 ` [PATCHv21 08/16] mm: mmzone: MIGRATE_CMA migration type added Marek Szyprowski
2012-02-14 8:29 ` KAMEZAWA Hiroyuki
2012-02-10 17:32 ` [PATCHv21 09/16] mm: page_isolation: MIGRATE_CMA isolation functions added Marek Szyprowski
2012-02-14 8:31 ` KAMEZAWA Hiroyuki
2012-02-10 17:32 ` [PATCHv21 10/16] mm: Serialize access to min_free_kbytes Marek Szyprowski
2012-02-14 8:38 ` KAMEZAWA Hiroyuki
2012-02-10 17:32 ` [PATCHv21 11/16] mm: extract reclaim code from __alloc_pages_direct_reclaim() Marek Szyprowski
2012-02-10 17:32 ` [PATCHv21 12/16] mm: trigger page reclaim in alloc_contig_range() to stabilise watermarks Marek Szyprowski
2012-02-13 18:57 ` [Linaro-mm-sig] " Robert Nelson
2012-02-13 19:38 ` Michal Nazarewicz
2012-02-13 21:15 ` Robert Nelson
2012-02-13 21:33 ` Michal Nazarewicz
2012-02-13 21:37 ` Robert Nelson
2012-02-10 17:32 ` [PATCHv21 13/16] drivers: add Contiguous Memory Allocator Marek Szyprowski
2012-02-10 17:32 ` [PATCHv21 14/16] X86: integrate CMA with DMA-mapping subsystem Marek Szyprowski
2012-02-10 17:32 ` [PATCHv21 15/16] ARM: " Marek Szyprowski
2012-02-10 17:32 ` Marek Szyprowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328895151-5196-17-git-send-email-m.szyprowski@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=benjamin.gaignard@linaro.org \
--cc=chunsang.jeong@linaro.org \
--cc=corbet@lwn.net \
--cc=dave@linux.vnet.ibm.com \
--cc=dwalker@codeaurora.org \
--cc=jesse.barker@linaro.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kyungmin.park@samsung.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=mel@csn.ul.ie \
--cc=mina86@mina86.com \
--cc=ohad@wizery.com \
--cc=rob.clark@linaro.org \
--cc=shariq.hasnain@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox