From: kosaki.motohiro@gmail.com
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: [PATCH 2/2] sysvshm: SHM_LOCK use lru_add_drain_all_async()
Date: Sun, 1 Jan 2012 02:30:25 -0500 [thread overview]
Message-ID: <1325403025-22688-2-git-send-email-kosaki.motohiro@gmail.com> (raw)
In-Reply-To: <CAHGf_=qA3Pnb00n_smhJVKDDCDDr0d-a3E03Rrhnb-S4xK8_fQ@mail.gmail.com>
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
shmctl also don't need synchrounous pagevec drain. This patch replace it with
lru_add_drain_all_async().
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
ipc/shm.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ipc/shm.c b/ipc/shm.c
index 02ecf2c..1eb25f0 100644
--- a/ipc/shm.c
+++ b/ipc/shm.c
@@ -872,8 +872,6 @@ SYSCALL_DEFINE3(shmctl, int, shmid, int, cmd, struct shmid_ds __user *, buf)
{
struct file *uninitialized_var(shm_file);
- lru_add_drain_all(); /* drain pagevecs to lru lists */
-
shp = shm_lock_check(ns, shmid);
if (IS_ERR(shp)) {
err = PTR_ERR(shp);
@@ -911,6 +909,8 @@ SYSCALL_DEFINE3(shmctl, int, shmid, int, cmd, struct shmid_ds __user *, buf)
shp->mlock_user = NULL;
}
shm_unlock(shp);
+ /* prevent user visible mismatch of unevictable accounting */
+ lru_add_drain_all_async();
goto out;
}
case IPC_RMID:
--
1.7.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-01-01 7:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-30 6:36 [PATCH] mm: do not drain pagevecs for mlock Tao Ma
2011-12-30 8:11 ` KOSAKI Motohiro
2011-12-30 8:48 ` Tao Ma
2011-12-30 9:31 ` KOSAKI Motohiro
2011-12-30 9:45 ` Tao Ma
2011-12-30 10:07 ` KOSAKI Motohiro
2012-01-01 7:30 ` [PATCH 1/2] mm,mlock: drain pagevecs asynchronously kosaki.motohiro
2012-01-04 1:17 ` Minchan Kim
2012-01-04 2:38 ` KOSAKI Motohiro
2012-01-10 8:53 ` Tao Ma
2012-01-04 2:56 ` Hugh Dickins
2012-01-04 22:05 ` Andrew Morton
2012-01-04 23:33 ` KOSAKI Motohiro
2012-01-05 0:19 ` Hugh Dickins
2012-01-01 7:30 ` kosaki.motohiro [this message]
2012-01-04 1:51 ` [PATCH 2/2] sysvshm: SHM_LOCK use lru_add_drain_all_async() Hugh Dickins
2012-01-04 2:19 ` KOSAKI Motohiro
2012-01-04 5:17 ` Hugh Dickins
2012-01-04 8:34 ` KOSAKI Motohiro
2012-01-06 6:13 ` [PATCH] mm: do not drain pagevecs for mlock Tao Ma
2012-01-06 6:18 ` KOSAKI Motohiro
2012-01-06 6:30 ` Tao Ma
2012-01-06 6:33 ` KOSAKI Motohiro
2012-01-06 6:46 ` Tao Ma
2012-01-09 23:58 ` KOSAKI Motohiro
2012-01-10 2:08 ` Tao Ma
2012-01-09 7:25 ` Tao Ma
2011-12-30 10:14 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1325403025-22688-2-git-send-email-kosaki.motohiro@gmail.com \
--to=kosaki.motohiro@gmail.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox