From: Kautuk Consul <consul.kautuk@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Cesar Eduardo Barros <cesarb@cesarb.net>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Eric B Munson <emunson@mgebm.net>,
Pekka Enberg <penberg@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Kautuk Consul <consul.kautuk@gmail.com>
Subject: [PATCH 1/1] swapfile: swap_info_get: Check for swap_info[type] == NULL
Date: Mon, 26 Dec 2011 17:26:39 +0530 [thread overview]
Message-ID: <1324900599-20804-1-git-send-email-consul.kautuk@gmail.com> (raw)
From: Kautuk Consul <consul.kautuk@gmail.com>
If the swapfile type encoded within entry.val is corrupted in
such a way that the swap_info[type] == NULL, then the code in
swap_info_get will cause a NULL pointer exception.
Assuming that the code in swap_info_get attempts to validate the
swapfile type by checking its range, another bad_nofile check would
be to check for check whether the swap_info[type] pointer is NULL.
Adding a NULL check for swap_info[type] to be reagrded as a "bad_nofile"
error scenario.
Signed-off-by: Kautuk Consul <consul.kautuk@gmail.com>
---
mm/swapfile.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/mm/swapfile.c b/mm/swapfile.c
index b1cd120..7bdbe91 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -483,6 +483,8 @@ static struct swap_info_struct *swap_info_get(swp_entry_t entry)
if (type >= nr_swapfiles)
goto bad_nofile;
p = swap_info[type];
+ if (!p)
+ goto bad_nofile;
if (!(p->flags & SWP_USED))
goto bad_device;
offset = swp_offset(entry);
--
1.7.6
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2011-12-26 11:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-26 11:56 Kautuk Consul [this message]
2011-12-26 17:45 ` Kautuk Consul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324900599-20804-1-git-send-email-consul.kautuk@gmail.com \
--to=consul.kautuk@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cesarb@cesarb.net \
--cc=emunson@mgebm.net \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox