From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx136.postini.com [74.125.245.136]) by kanga.kvack.org (Postfix) with SMTP id 298E96B004D for ; Wed, 21 Dec 2011 00:58:21 -0500 (EST) Message-ID: <1324447099.21340.6.camel@joe2Laptop> Subject: Re: [PATCH] vmalloc: remove #ifdef in function body From: Joe Perches Date: Tue, 20 Dec 2011 21:58:19 -0800 In-Reply-To: <20111221054531.GB28505@barrios-laptop.redhat.com> References: <1324444679-9247-1-git-send-email-minchan@kernel.org> <1324445481.20505.7.camel@joe2Laptop> <20111221054531.GB28505@barrios-laptop.redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: Andrew Morton , linux-mm , LKML On Wed, 2011-12-21 at 14:45 +0900, Minchan Kim wrote: > On Tue, Dec 20, 2011 at 09:31:21PM -0800, Joe Perches wrote: > > On Wed, 2011-12-21 at 14:17 +0900, Minchan Kim wrote: > > > We don't like function body which include #ifdef. [] > > I don't like this change. > > I think it's perfectly good style to use: > I feel it's no problem as it is because it's very short function now > but it's not style we prefer. Who is this "we" you refer to? There's nothing suggesting your patch as a preferred style in Documentation/CodingStyle. cheers, Joe -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org