Re: [PATCH] Put braces around potentially empty 'if' body in handle_pte_fault()

[Eric Dumazet <eric.dumazet@gmail.com>]

Le dimanche 18 dA(C)cembre 2011 A  01:03 +0100, Jesper Juhl a A(C)crit :
> If one builds the kernel with -Wempty-body one gets this warning:
> 
>   mm/memory.c:3432:46: warning: suggest braces around empty body in an a??ifa?? statement [-Wempty-body]
> 
> due to the fact that 'flush_tlb_fix_spurious_fault' is a macro that
> can sometimes be defined to nothing.
> 
> I suggest we heed gcc's advice and put a pair of braces on that if.
> 
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
>  mm/memory.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/mm/memory.c b/mm/memory.c
> index 829d437..9cf1b48 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -3428,9 +3428,9 @@ int handle_pte_fault(struct mm_struct *mm,
>  		 * This still avoids useless tlb flushes for .text page faults
>  		 * with threads.
>  		 */
> -		if (flags & FAULT_FLAG_WRITE)
> +		if (flags & FAULT_FLAG_WRITE) {
>  			flush_tlb_fix_spurious_fault(vma, address);
> +		}
>  	}
>  unlock:
>  	pte_unmap_unlock(pte, ptl);
> -- 
> 1.7.8
> 

Thats should be fixed in the reverse way :

#define flush_tlb_fix_spurious_fault(vma, address) do { } while (0)



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>