From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx207.postini.com [74.125.245.207]) by kanga.kvack.org (Postfix) with SMTP id BBD816B02D0 for ; Wed, 14 Dec 2011 05:51:22 -0500 (EST) Subject: Re: [PATCH] mm: Fix kswapd livelock on single core, no preempt kernel From: James Bottomley In-Reply-To: <1323798271-1452-1-git-send-email-mikew@google.com> References: <1323798271-1452-1-git-send-email-mikew@google.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 14 Dec 2011 14:51:16 +0400 Message-ID: <1323859876.3063.39.camel@dabdike> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Mike Waychison Cc: Andrew Morton , Mel Gorman , Minchan Kim , KAMEZAWA Hiroyuki , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickens , Greg Thelen On Tue, 2011-12-13 at 09:44 -0800, Mike Waychison wrote: > On a single core system with kernel preemption disabled, it is possible > for the memory system to be so taxed that kswapd cannot make any forward > progress. This can happen when most of system memory is tied up as > anonymous memory without swap enabled, causing kswapd to consistently > fail to achieve its watermark goals. In turn, sleeping_prematurely() > will consistently return true and kswapd_try_to_sleep() to never invoke > schedule(). This causes the kswapd thread to stay on the CPU in > perpetuity and keeps other threads from processing oom-kills to reclaim > memory. > > The cond_resched() instance in balance_pgdat() is never called as the > loop that iterates from DEF_PRIORITY down to 0 will always set > all_zones_ok to true, and not set it to false once we've passed > DEF_PRIORITY as zones that are marked ->all_unreclaimable are not > considered in the "all_zones_ok" evaluation. > > This change modifies kswapd_try_to_sleep to ensure that we enter > scheduler at least once per invocation if needed. This allows kswapd to > get off the CPU and allows other threads to die off from the OOM killer > (freeing memory that is otherwise unavailable in the process). This keeps cropping up. I think it's not the same as the last time I saw it (which was on a multi-core system) but it was definitely caused by an issue with sleeping_prematurely(). For reference, this is the thread: http://marc.info/?t=130436700400001 And this was the eventual fix that worked for me: http://marc.info/?t=130892304300003 James -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org