From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with ESMTP id F0DD99000CF for ; Sun, 25 Sep 2011 04:56:20 -0400 (EDT) Received: by ywe9 with SMTP id 9so4860039ywe.14 for ; Sun, 25 Sep 2011 01:56:19 -0700 (PDT) From: Gilad Ben-Yossef Subject: [PATCH 5/5] slub: Only IPI CPUs that have per cpu obj to flush Date: Sun, 25 Sep 2011 11:54:50 +0300 Message-Id: <1316940890-24138-6-git-send-email-gilad@benyossef.com> In-Reply-To: <1316940890-24138-1-git-send-email-gilad@benyossef.com> References: <1316940890-24138-1-git-send-email-gilad@benyossef.com> Sender: owner-linux-mm@kvack.org List-ID: To: linux-kernel@vger.kernel.org Cc: Gilad Ben-Yossef , Peter Zijlstra , Frederic Weisbecker , Russell King , Chris Metcalf , linux-mm@kvack.org, Christoph Lameter , Pekka Enberg , Matt Mackall Try to send IPI to flush per cpu objects back to free lists to CPUs to seems to have such objects. The check which CPU to IPI is racy but we don't care since asking a CPU without per cpu objects to flush does no damage and as far as I can tell the flush_all by itself is racy against allocs on remote CPUs anyway, so if you meant the flush_all to be determinstic, you had to arrange for locking regardless. Signed-off-by: Gilad Ben-Yossef CC: Peter Zijlstra CC: Frederic Weisbecker CC: Russell King CC: Chris Metcalf CC: linux-mm@kvack.org CC: Christoph Lameter CC: Pekka Enberg CC: Matt Mackall --- mm/slub.c | 15 ++++++++++++++- 1 files changed, 14 insertions(+), 1 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 9f662d7..8baae30 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -1948,7 +1948,20 @@ static void flush_cpu_slab(void *d) static void flush_all(struct kmem_cache *s) { - on_each_cpu(flush_cpu_slab, s, 1); + cpumask_var_t cpus; + struct kmem_cache_cpu *c; + int cpu; + + if (likely(zalloc_cpumask_var(&cpus, GFP_ATOMIC))) { + for_each_online_cpu(cpu) { + c = per_cpu_ptr(s->cpu_slab, cpu); + if (c && c->page) + cpumask_set_cpu(cpu, cpus); + } + on_each_cpu_mask(cpus, flush_cpu_slab, s, 1); + free_cpumask_var(cpus); + } else + on_each_cpu(flush_cpu_slab, s, 1); } /* -- 1.7.0.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org