From: Gilad Ben-Yossef <gilad@benyossef.com>
To: linux-kernel@vger.kernel.org
Cc: Gilad Ben-Yossef <gilad@benyossef.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Frederic Weisbecker <fweisbec@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Chris Metcalf <cmetcalf@tilera.com>,
linux-mm@kvack.org, Christoph Lameter <cl@linux-foundation.org>,
Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>
Subject: [PATCH 5/5] slub: Only IPI CPUs that have per cpu obj to flush
Date: Sun, 25 Sep 2011 11:54:50 +0300 [thread overview]
Message-ID: <1316940890-24138-6-git-send-email-gilad@benyossef.com> (raw)
In-Reply-To: <1316940890-24138-1-git-send-email-gilad@benyossef.com>
Try to send IPI to flush per cpu objects back to free lists
to CPUs to seems to have such objects.
The check which CPU to IPI is racy but we don't care since
asking a CPU without per cpu objects to flush does no
damage and as far as I can tell the flush_all by itself is
racy against allocs on remote CPUs anyway, so if you meant
the flush_all to be determinstic, you had to arrange for
locking regardless.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
CC: Frederic Weisbecker <fweisbec@gmail.com>
CC: Russell King <linux@arm.linux.org.uk>
CC: Chris Metcalf <cmetcalf@tilera.com>
CC: linux-mm@kvack.org
CC: Christoph Lameter <cl@linux-foundation.org>
CC: Pekka Enberg <penberg@kernel.org>
CC: Matt Mackall <mpm@selenic.com>
---
mm/slub.c | 15 ++++++++++++++-
1 files changed, 14 insertions(+), 1 deletions(-)
diff --git a/mm/slub.c b/mm/slub.c
index 9f662d7..8baae30 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -1948,7 +1948,20 @@ static void flush_cpu_slab(void *d)
static void flush_all(struct kmem_cache *s)
{
- on_each_cpu(flush_cpu_slab, s, 1);
+ cpumask_var_t cpus;
+ struct kmem_cache_cpu *c;
+ int cpu;
+
+ if (likely(zalloc_cpumask_var(&cpus, GFP_ATOMIC))) {
+ for_each_online_cpu(cpu) {
+ c = per_cpu_ptr(s->cpu_slab, cpu);
+ if (c && c->page)
+ cpumask_set_cpu(cpu, cpus);
+ }
+ on_each_cpu_mask(cpus, flush_cpu_slab, s, 1);
+ free_cpumask_var(cpus);
+ } else
+ on_each_cpu(flush_cpu_slab, s, 1);
}
/*
--
1.7.0.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-09-25 8:56 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-25 8:54 [PATCH 0/5] Reduce cross CPU IPI interference Gilad Ben-Yossef
2011-09-25 8:54 ` [PATCH 1/5] smp: Introduce a generic on_each_cpu_mask function Gilad Ben-Yossef
2011-09-25 11:37 ` Sasha Levin
2011-09-26 8:48 ` Peter Zijlstra
2011-09-25 8:54 ` [PATCH 2/5] arm: Move arm over to generic on_each_cpu_mask Gilad Ben-Yossef
2011-09-25 8:54 ` [PATCH 3/5] tile: Move tile to use " Gilad Ben-Yossef
2011-09-25 8:54 ` [PATCH 4/5] mm: Only IPI CPUs to drain local pages if they exist Gilad Ben-Yossef
2011-09-26 1:52 ` Shaohua Li
2011-09-26 6:47 ` Gilad Ben-Yossef
2011-09-26 15:24 ` Christoph Lameter
2011-09-27 7:27 ` Gilad Ben-Yossef
2011-09-27 16:13 ` Christoph Lameter
2011-09-26 7:28 ` Peter Zijlstra
2011-09-26 8:39 ` Gilad Ben-Yossef
2011-09-26 7:29 ` Peter Zijlstra
2011-09-25 8:54 ` Gilad Ben-Yossef [this message]
2011-09-26 6:54 ` [PATCH 5/5] slub: Only IPI CPUs that have per cpu obj to flush Pekka Enberg
2011-09-26 7:36 ` Peter Zijlstra
2011-09-26 8:07 ` Gilad Ben-Yossef
2011-09-26 10:03 ` Pekka Enberg
2011-09-26 8:10 ` Gilad Ben-Yossef
2011-09-26 7:33 ` Peter Zijlstra
2011-09-26 8:35 ` Gilad Ben-Yossef
2011-09-26 9:28 ` Pekka Enberg
2011-09-26 9:45 ` Peter Zijlstra
2011-09-26 12:05 ` Gilad Ben-Yossef
2011-09-26 13:49 ` Gilad Ben-Yossef
2011-09-26 7:20 ` [PATCH 0/5] Reduce cross CPU IPI interference Peter Zijlstra
2011-09-26 8:43 ` Gilad Ben-Yossef
2011-09-26 8:46 ` Peter Zijlstra
2011-09-28 13:00 ` Chris Metcalf
2011-10-02 8:44 ` Gilad Ben-Yossef
2011-10-02 14:58 ` Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316940890-24138-6-git-send-email-gilad@benyossef.com \
--to=gilad@benyossef.com \
--cc=a.p.zijlstra@chello.nl \
--cc=cl@linux-foundation.org \
--cc=cmetcalf@tilera.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox