Re: [PATCH 1/2] slub: remove obsolete code path in __slab_free() for per cpu partial

["Alex,Shi" <alex.shi@intel.com>]

Resend for correction CC e-mail address. Sorry. 

On Fri, 2011-09-09 at 17:02 +0800, Alex,Shi wrote:
> If there are still some objects left in slab, the slab page will be put
> to per cpu partial list. So remove the obsolete code path.
> 
> 
> Signed-off-by: Alex Shi <alex.shi@intel.com>
> ---
>  mm/slub.c |   13 +------------
>  1 files changed, 1 insertions(+), 12 deletions(-)
> 
> diff --git a/mm/slub.c b/mm/slub.c
> index 492beab..bca8eee 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -2526,20 +2526,9 @@ static void __slab_free(struct kmem_cache *s, struct page *page,
>  	 */
>  	if (was_frozen)
>  		stat(s, FREE_FROZEN);
> -	else {
> -		if (unlikely(!inuse && n->nr_partial > s->min_partial))
> +	else if (unlikely(!inuse && n->nr_partial > s->min_partial))
>                          goto slab_empty;
>  
> -		/*
> -		 * Objects left in the slab. If it was not on the partial list before
> -		 * then add it.
> -		 */
> -		if (unlikely(!prior)) {
> -			remove_full(s, page);
> -			add_partial(n, page, 0);
> -			stat(s, FREE_ADD_PARTIAL);
> -		}
> -	}
>  	spin_unlock_irqrestore(&n->list_lock, flags);
>  	return;
>  


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>