From: Eric Dumazet <eric.dumazet@gmail.com>
To: Greg Thelen <gthelen@google.com>
Cc: Glauber Costa <glommer@parallels.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
containers@lists.osdl.org, netdev@vger.kernel.org,
xemul@parallels.com, "David S. Miller" <davem@davemloft.net>,
Hiroyouki Kamezawa <kamezawa.hiroyu@jp.fujitsu.com>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH] per-cgroup tcp buffer limitation
Date: Wed, 07 Sep 2011 04:38:40 +0200 [thread overview]
Message-ID: <1315363120.3400.54.camel@edumazet-laptop> (raw)
In-Reply-To: <CAHH2K0YJA7vZZ3QNAf63TZOnWhsRUwfuZYfntBL4muZ0G_Vt2w@mail.gmail.com>
Le mardi 06 septembre 2011 A 15:12 -0700, Greg Thelen a A(C)crit :
> >>> +#define sk_sockets_allocated(sk) \
> >>> +({ \
> >>> + struct percpu_counter *__p; \
> >>> + __p = (sk)->sk_prot->sockets_allocated(sk->sk_cgrp); \
> >>> + __p; \
> >>> +})
>
> Could this be simplified as (same applies to following few macros):
>
> static inline struct percpu_counter *sk_sockets_allocated(struct sock *sk)
> {
> return sk->sk_prot->sockets_allocated(sk->sk_cgrp);
> }
>
Please Greg, dont copy/paste huge sequence of code if you dont have
anymore comments.
Right before sending your mail, remove all parts that we already got in
previous mails.
Thanks
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-09-07 2:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-06 2:35 Glauber Costa
2011-09-06 10:00 ` KAMEZAWA Hiroyuki
2011-09-06 15:28 ` Glauber Costa
2011-09-06 22:52 ` Glauber Costa
2011-09-06 16:08 ` Greg Thelen
2011-09-06 16:16 ` Glauber Costa
2011-09-06 22:12 ` Greg Thelen
2011-09-06 22:37 ` Glauber Costa
2011-09-07 21:35 ` Greg Thelen
2011-09-08 4:44 ` Glauber Costa
2011-09-08 21:53 ` Greg Thelen
2011-09-09 4:17 ` Glauber Costa
2011-09-09 23:38 ` Greg Thelen
2011-09-12 16:30 ` Glauber Costa
2011-09-12 5:03 ` Paul Menage
2011-09-12 16:57 ` Glauber Costa
2011-09-13 6:56 ` Greg Thelen
2011-09-13 18:09 ` Paul Menage
2011-09-13 18:11 ` Glauber Costa
2011-09-13 18:46 ` Paul Menage
2011-09-13 19:08 ` Glauber Costa
2011-09-07 2:38 ` Eric Dumazet [this message]
2011-09-07 1:08 ` Paul Menage
2011-09-07 1:09 ` Glauber Costa
2011-09-07 1:29 ` Paul Menage
2011-09-07 1:32 ` Glauber Costa
2011-09-09 0:18 ` Rick Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315363120.3400.54.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=containers@lists.osdl.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=glommer@parallels.com \
--cc=gthelen@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox