From: Kautuk Consul <consul.kautuk@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <jaxboe@fusionio.com>,
Wu Fengguang <fengguang.wu@intel.com>, Jan Kara <jack@suse.cz>,
Dave Chinner <dchinner@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Kautuk Consul <consul.kautuk@gmail.com>
Subject: [PATCH 1/1] mm/backing-dev.c: Call del_timer_sync instead of del_timer
Date: Thu, 1 Sep 2011 21:27:02 +0530 [thread overview]
Message-ID: <1314892622-18267-1-git-send-email-consul.kautuk@gmail.com> (raw)
This is important for SMP scenario, to check whether the timer
callback is executing on another CPU when we are deleting the
timer.
Signed-off-by: Kautuk Consul <consul.kautuk@gmail.com>
---
mm/backing-dev.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index d6edf8d..754b35a 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -385,7 +385,7 @@ static int bdi_forker_thread(void *ptr)
* dirty data on the default backing_dev_info
*/
if (wb_has_dirty_io(me) || !list_empty(&me->bdi->work_list)) {
- del_timer(&me->wakeup_timer);
+ del_timer_sync(&me->wakeup_timer);
wb_do_writeback(me, 0);
}
--
1.7.4.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2011-09-01 15:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 15:57 Kautuk Consul [this message]
2011-09-01 21:33 ` Andrew Morton
2011-09-02 5:17 ` kautuk.c @samsung.com
2011-09-02 11:21 ` Jan Kara
2011-09-02 11:44 ` kautuk.c @samsung.com
2011-09-02 12:02 ` kautuk.c @samsung.com
2011-09-02 15:14 ` Jan Kara
2011-09-05 5:49 ` kautuk.c @samsung.com
2011-09-05 10:39 ` Jan Kara
2011-09-05 14:36 ` kautuk.c @samsung.com
2011-09-05 16:05 ` Jan Kara
2011-09-06 4:11 ` kautuk.c @samsung.com
2011-09-06 9:14 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314892622-18267-1-git-send-email-consul.kautuk@gmail.com \
--to=consul.kautuk@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dchinner@redhat.com \
--cc=fengguang.wu@intel.com \
--cc=jack@suse.cz \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox