From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta7.messagelabs.com (mail6.bemta7.messagelabs.com [216.82.255.55]) by kanga.kvack.org (Postfix) with ESMTP id CA2326B00EE for ; Tue, 30 Aug 2011 22:27:37 -0400 (EDT) Subject: Re: [patch 2/2]slub: explicitly document position of inserting slab to partial list From: Shaohua Li In-Reply-To: References: <1314669252.29510.49.camel@sli10-conroe> Content-Type: text/plain; charset="UTF-8" Date: Wed, 31 Aug 2011 10:29:48 +0800 Message-ID: <1314757788.29510.59.camel@sli10-conroe> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Lameter Cc: Andrew Morton , "penberg@kernel.org" , "Shi, Alex" , "Chen, Tim C" , linux-mm On Tue, 2011-08-30 at 21:48 +0800, Christoph Lameter wrote: > On Tue, 30 Aug 2011, Shaohua Li wrote: > > > Adding slab to partial list head/tail is sensitive to performance. Using 0/1 > > can easily cause typo. So explicitly uses DEACTIVATE_TO_TAIL/DEACTIVATE_TO_HEAD > > to document it to avoid we get it wrong. > > I dont think we want this patch anymore. I do think using 0/1 isn't good. A more meaningful name is better to avoid typo. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org