From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id 847096B016A for ; Mon, 22 Aug 2011 21:47:02 -0400 (EDT) Subject: Re: [patch 1/2]slub: add slab with one free object to partial list tail From: Shaohua Li In-Reply-To: <1314059819.29510.18.camel@sli10-conroe> References: <1314059819.29510.18.camel@sli10-conroe> Content-Type: text/plain; charset="UTF-8" Date: Tue, 23 Aug 2011 09:48:18 +0800 Message-ID: <1314064098.29510.23.camel@sli10-conroe> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: linux-mm , lkml , cl@linux.com, penberg@kernel.org, "Shi, Alex" , "Chen, Tim C" On Tue, 2011-08-23 at 08:36 +0800, Shaohua Li wrote: > The slab has just one free object, adding it to partial list head doesn't make > sense. And it can cause lock contentation. For example, > 1. CPU takes the slab from partial list > 2. fetch an object > 3. switch to another slab > 4. free an object, then the slab is added to partial list again > In this way n->list_lock will be heavily contended. > In fact, Alex had a hackbench regression. 3.1-rc1 performance drops about 70% > against 3.0. This patch fixes it. updated the change log a little bit. My apologize to not mention Alex's credit. Thanks, Shaohua The slab has just one free object, adding it to partial list head doesn't make sense. And it can cause lock contentation. For example, 1. CPU takes the slab from partial list 2. fetch an object 3. switch to another slab 4. free an object, then the slab is added to partial list again In this way n->list_lock will be heavily contended. In fact, Alex had a hackbench regression. 3.1-rc1 performance drops about 70% against 3.0. This patch fixes it. Thanks Alex to bisect the issue to be a slub regression and collect perf data. Reported-by: Alex Shi Signed-off-by: Shaohua Li Signed-off-by: Shaohua Li --- mm/slub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux/mm/slub.c =================================================================== --- linux.orig/mm/slub.c 2011-08-15 09:55:21.000000000 +0800 +++ linux/mm/slub.c 2011-08-23 08:13:54.000000000 +0800 @@ -2377,7 +2377,7 @@ static void __slab_free(struct kmem_cach */ if (unlikely(!prior)) { remove_full(s, page); - add_partial(n, page, 0); + add_partial(n, page, 1); stat(s, FREE_ADD_PARTIAL); } } -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org