From: Shaohua Li <shaohua.li@intel.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm <linux-mm@kvack.org>
Subject: Re: [patch]mm: fix a memcg warning
Date: Mon, 01 Aug 2011 14:57:08 +0800 [thread overview]
Message-ID: <1312181828.15392.428.camel@sli10-conroe> (raw)
In-Reply-To: <20110801153700.e6f1c9b9.kamezawa.hiroyu@jp.fujitsu.com>
On Mon, 2011-08-01 at 14:37 +0800, KAMEZAWA Hiroyuki wrote:
> On Mon, 01 Aug 2011 14:41:18 +0800
> Shaohua Li <shaohua.li@intel.com> wrote:
>
> > I get below warning:
> > BUG: using smp_processor_id() in preemptible [00000000] code: bash/739
> > caller is drain_local_stock+0x1a/0x55
> > Pid: 739, comm: bash Tainted: G W 3.0.0+ #255
> > Call Trace:
> > [<ffffffff813435c6>] debug_smp_processor_id+0xc2/0xdc
> > [<ffffffff8114ae9b>] drain_local_stock+0x1a/0x55
> > [<ffffffff8114b076>] drain_all_stock+0x98/0x13a
> > [<ffffffff8114f04c>] mem_cgroup_force_empty+0xa3/0x27a
> > [<ffffffff8114ff1d>] ? sys_close+0x38/0x138
> > [<ffffffff811a7631>] ? environ_read+0x1d/0x159
> > [<ffffffff8114f253>] mem_cgroup_force_empty_write+0x17/0x19
> > [<ffffffff810c72fb>] cgroup_file_write+0xa8/0xba
> > [<ffffffff811522ce>] vfs_write+0xb3/0x138
> > [<ffffffff81152416>] sys_write+0x4a/0x71
> > [<ffffffff8114ffd5>] ? sys_close+0xf0/0x138
> > [<ffffffff8176deab>] system_call_fastpath+0x16/0x1b
> >
> > drain_local_stock() should be run with preempt disabled.
> >
> > Signed-off-by: Shaohua Li <shaohua.li@intel.com>
> >
>
> Thanks,
> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
> IIUC, I myself didn't see this warning when I wrote codes.
> Do I need to set some CONFIG ?
I thought it's CONFIG_DEBUG_PREEMPT=y
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-08-01 6:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 6:41 Shaohua Li
2011-08-01 6:37 ` KAMEZAWA Hiroyuki
2011-08-01 6:57 ` Shaohua Li [this message]
2011-08-01 12:12 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312181828.15392.428.camel@sli10-conroe \
--to=shaohua.li@intel.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox