* [patch 2/3]vmscan: count pages into balanced for zone with good watermark
@ 2011-07-28 8:13 Shaohua Li
2011-07-28 10:59 ` Mel Gorman
2011-07-29 9:28 ` Minchan Kim
0 siblings, 2 replies; 3+ messages in thread
From: Shaohua Li @ 2011-07-28 8:13 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-mm, mgorman, Minchan Kim
It's possible a zone watermark is ok at entering balance_pgdat loop, while the
zone is within requested classzone_idx. Countering pages from the zone into
balanced. In this way, we can skip shrinking zones too much for high
order allocation.
Signed-off-by: Shaohua Li <shaohua.li@intel.com>
---
mm/vmscan.c | 2 ++
1 file changed, 2 insertions(+)
Index: linux/mm/vmscan.c
===================================================================
--- linux.orig/mm/vmscan.c 2011-07-28 15:17:56.000000000 +0800
+++ linux/mm/vmscan.c 2011-07-28 15:34:48.000000000 +0800
@@ -2497,6 +2497,8 @@ loop_again:
} else {
/* If balanced, clear the congested flag */
zone_clear_flag(zone, ZONE_CONGESTED);
+ if (i <= *classzone_idx)
+ balanced += zone->present_pages;
}
}
if (i < 0)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch 2/3]vmscan: count pages into balanced for zone with good watermark
2011-07-28 8:13 [patch 2/3]vmscan: count pages into balanced for zone with good watermark Shaohua Li
@ 2011-07-28 10:59 ` Mel Gorman
2011-07-29 9:28 ` Minchan Kim
1 sibling, 0 replies; 3+ messages in thread
From: Mel Gorman @ 2011-07-28 10:59 UTC (permalink / raw)
To: Shaohua Li; +Cc: Andrew Morton, linux-mm, Minchan Kim
On Thu, Jul 28, 2011 at 04:13:05PM +0800, Shaohua Li wrote:
> It's possible a zone watermark is ok at entering balance_pgdat loop, while the
> zone is within requested classzone_idx. Countering pages from the zone into
> balanced. In this way, we can skip shrinking zones too much for high
> order allocation.
>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 2/3]vmscan: count pages into balanced for zone with good watermark
2011-07-28 8:13 [patch 2/3]vmscan: count pages into balanced for zone with good watermark Shaohua Li
2011-07-28 10:59 ` Mel Gorman
@ 2011-07-29 9:28 ` Minchan Kim
1 sibling, 0 replies; 3+ messages in thread
From: Minchan Kim @ 2011-07-29 9:28 UTC (permalink / raw)
To: Shaohua Li; +Cc: Andrew Morton, linux-mm, mgorman
On Thu, Jul 28, 2011 at 04:13:05PM +0800, Shaohua Li wrote:
> It's possible a zone watermark is ok at entering balance_pgdat loop, while the
> zone is within requested classzone_idx. Countering pages from the zone into
> balanced. In this way, we can skip shrinking zones too much for high
> order allocation.
>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
Nice catch, Shaohua!
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-07-29 9:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-28 8:13 [patch 2/3]vmscan: count pages into balanced for zone with good watermark Shaohua Li
2011-07-28 10:59 ` Mel Gorman
2011-07-29 9:28 ` Minchan Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox