From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with SMTP id 05BDA6B004A for ; Wed, 20 Jul 2011 14:07:20 -0400 (EDT) Subject: Re: [PATCH] mm-slab: allocate kmem_cache with __GFP_REPEAT From: Matt Mackall In-Reply-To: References: <20110720121612.28888.38970.stgit@localhost6> <20110720134342.GK5349@suse.de> <1311170893.2338.29.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> <1311174562.2338.42.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> <1311177362.2338.57.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> <1311179465.2338.62.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> <1311181463.2338.72.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> Content-Type: text/plain; charset="UTF-8" Date: Wed, 20 Jul 2011 13:07:04 -0500 Message-ID: <1311185224.14555.43.camel@calx> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Pekka Enberg Cc: Christoph Lameter , Eric Dumazet , Mel Gorman , Konstantin Khlebnikov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Wed, 2011-07-20 at 20:41 +0300, Pekka Enberg wrote: > On Wed, 20 Jul 2011, Pekka Enberg wrote: > >> On Wed, 20 Jul 2011, Eric Dumazet wrote: > >>>> [PATCH v2] slab: shrinks sizeof(struct kmem_cache) > >> > >> On Wed, 20 Jul 2011, Christoph Lameter wrote: > >>> This will solve the issue for small nr_cpu_ids but those with 4k cpus will > >>> still have the issue. > >>> > >>> Acked-by: Christoph Lameter > >> > >> Applied, thanks! Do we still want the __GFP_REPEAT patch from Konstantin > >> though? > > On Wed, 20 Jul 2011, Christoph Lameter wrote: > > Those with 4k cpus will be thankful I guess. > > OTOH, I'm slightly worried that it might mask a real problem > with GFP_KERNEL not being aggressive enough. Mel? I think that's already been demonstrated here, yes. It's just waiting for another obscure workload to trigger it. -- Mathematics is the supreme nostalgia of our time. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org