linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Bob Liu <lliubbo@gmail.com>
To: akpm@linux-foundation.org
Cc: gerg@snapgear.com, dhowells@redhat.com, lethal@linux-sh.org,
	geert@linux-m68k.org, vapier@gentoo.org, linux-mm@kvack.org,
	Bob Liu <lliubbo@gmail.com>
Subject: [PATCH] mm: nommu: fix remap_pfn_range()
Date: Fri, 27 May 2011 11:50:03 +0800	[thread overview]
Message-ID: <1306468203-8683-1-git-send-email-lliubbo@gmail.com> (raw)

remap_pfn_range() does not update vma->end on no mmu arch which will
cause munmap() fail because it can't match the vma.

eg. fb_mmap() in fbmem.c will call io_remap_pfn_range() which is
remap_pfn_range() on nommu arch, if an address is not page aligned vma->start
will be changed in remap_pfn_range(), but neither size nor vma->end will be
updated. Then munmap(start, len) can't find the vma to free, because it need to
compare (start + len) with vma->end.

Signed-off-by: Bob Liu <lliubbo@gmail.com>
---
 mm/nommu.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/mm/nommu.c b/mm/nommu.c
index 1fd0c51..829848a 100644
--- a/mm/nommu.c
+++ b/mm/nommu.c
@@ -1817,6 +1817,7 @@ int remap_pfn_range(struct vm_area_struct *vma, unsigned long from,
 		unsigned long to, unsigned long size, pgprot_t prot)
 {
 	vma->vm_start = vma->vm_pgoff << PAGE_SHIFT;
+	vma->vm_end = vma->vm_start + size;
 	return 0;
 }
 EXPORT_SYMBOL(remap_pfn_range);
-- 
1.6.3.3


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2011-05-27  3:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-27  3:50 Bob Liu [this message]
2011-05-27 22:09 ` Andrew Morton
2011-06-02  6:19   ` Bob Liu
2011-05-27 22:12 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306468203-8683-1-git-send-email-lliubbo@gmail.com \
    --to=lliubbo@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=geert@linux-m68k.org \
    --cc=gerg@snapgear.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-mm@kvack.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox