From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with SMTP id 2DB946B0022 for ; Mon, 16 May 2011 19:22:44 -0400 (EDT) Subject: Re: [PATCH 3/3] checkpatch.pl: Add check for task comm references From: Joe Perches In-Reply-To: References: <1305580757-13175-1-git-send-email-john.stultz@linaro.org> <1305580757-13175-4-git-send-email-john.stultz@linaro.org> <1305587090.2503.42.camel@Joe-Laptop> Content-Type: text/plain; charset="UTF-8" Date: Mon, 16 May 2011 16:22:41 -0700 Message-ID: <1305588161.2503.46.camel@Joe-Laptop> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Nazarewicz Cc: David Rientjes , Andy Whitcroft , LKML , John Stultz , Ted Ts'o , Jiri Slaby , KOSAKI Motohiro , Dave Hansen , Andrew Morton , linux-mm@kvack.org On Tue, 2011-05-17 at 01:11 +0200, Michal Nazarewicz wrote: > On Tue, 17 May 2011 01:04:50 +0200, Joe Perches wrote: > > On Mon, 2011-05-16 at 14:34 -0700, David Rientjes wrote: > >> On Mon, 16 May 2011, Michal Nazarewicz wrote: > >> > > Now that accessing current->comm needs to be protected, > >> > > +# check for current->comm usage > >> > > + if ($line =~ /\b(?:current|task|tsk|t)\s*->\s*comm\b/) { > >> > Not a checkpatch.pl expert but as far as I'm concerned, that looks > >> reasonable. > > You don't need (?: just ( > Yep, it's a micro-optimisation though. True, but it's not the common style in checkpatch. You could submit patches to add non-capture markers to other () uses. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org