From: Stephen Wilson <wilsons@start.ca>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Stephen Wilson <wilsons@start.ca>,
Hugh Dickins <hughd@google.com>,
David Rientjes <rientjes@google.com>,
Lee Schermerhorn <lee.schermerhorn@hp.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Christoph Lameter <cl@linux-foundation.org>,
Randy Dunlap <rdunlap@xenotime.net>
Subject: [PATCH v2 6/9] mm: declare mpol_to_str() when CONFIG_TMPFS=n
Date: Sun, 15 May 2011 18:20:26 -0400 [thread overview]
Message-ID: <1305498029-11677-7-git-send-email-wilsons@start.ca> (raw)
In-Reply-To: <1305498029-11677-1-git-send-email-wilsons@start.ca>
When CONFIG_TMPFS=n mpol_to_str() is not declared in mempolicy.h.
However, in the NUMA case, the definition is always compiled.
Since it is not strictly true that tmpfs is the only client, and since
the symbol was always lurking around anyways, export mpol_to_str()
unconditionally. Furthermore, this will allow us to move
show_numa_map() out of mempolicy.c and into the procfs subsystem.
Signed-off-by: Stephen Wilson <wilsons@start.ca>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: David Rientjes <rientjes@google.com>
Cc: Lee Schermerhorn <lee.schermerhorn@hp.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Christoph Lameter <cl@linux-foundation.org>
Cc: Randy Dunlap <rdunlap@xenotime.net>
---
include/linux/mempolicy.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/mempolicy.h b/include/linux/mempolicy.h
index c2f6032..7978eec 100644
--- a/include/linux/mempolicy.h
+++ b/include/linux/mempolicy.h
@@ -231,10 +231,10 @@ int do_migrate_pages(struct mm_struct *mm,
#ifdef CONFIG_TMPFS
extern int mpol_parse_str(char *str, struct mempolicy **mpol, int no_context);
+#endif
extern int mpol_to_str(char *buffer, int maxlen, struct mempolicy *pol,
int no_context);
-#endif
/* Check if a vma is migratable */
static inline int vma_migratable(struct vm_area_struct *vma)
@@ -371,13 +371,13 @@ static inline int mpol_parse_str(char *str, struct mempolicy **mpol,
{
return 1; /* error */
}
+#endif
static inline int mpol_to_str(char *buffer, int maxlen, struct mempolicy *pol,
int no_context)
{
return 0;
}
-#endif
#endif /* CONFIG_NUMA */
#endif /* __KERNEL__ */
--
1.7.4.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-05-15 22:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-15 22:20 [PATCH v2 0/9] avoid allocation in show_numa_map() Stephen Wilson
2011-05-15 22:20 ` [PATCH v2 1/9] mm: export get_vma_policy() Stephen Wilson
2011-05-15 22:20 ` [PATCH v2 2/9] mm: use walk_page_range() instead of custom page table walking code Stephen Wilson
2011-05-15 22:20 ` [PATCH v2 3/9] mm: remove MPOL_MF_STATS Stephen Wilson
2011-05-15 22:20 ` [PATCH v2 4/9] mm: make gather_stats() type-safe and remove forward declaration Stephen Wilson
2011-05-18 0:01 ` KOSAKI Motohiro
2011-05-15 22:20 ` [PATCH v2 5/9] mm: remove check_huge_range() Stephen Wilson
2011-05-15 22:20 ` Stephen Wilson [this message]
2011-05-15 22:20 ` [PATCH v2 7/9] mm: proc: move show_numa_map() to fs/proc/task_mmu.c Stephen Wilson
2011-05-18 0:02 ` KOSAKI Motohiro
2011-05-15 22:20 ` [PATCH v2 8/9] proc: make struct proc_maps_private truly private Stephen Wilson
2011-05-15 22:20 ` [PATCH v2 9/9] proc: allocate storage for numa_maps statistics once Stephen Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305498029-11677-7-git-send-email-wilsons@start.ca \
--to=wilsons@start.ca \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=hughd@google.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=lee.schermerhorn@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rdunlap@xenotime.net \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox