Re: 2.6.39-rc4+: Kernel leaking memory during FS scanning, regression?

[Mike Galbraith <efault@gmx.de>]

On Thu, 2011-04-28 at 11:40 +0200, Thomas Gleixner wrote:
> On Thu, 28 Apr 2011, Sedat Dilek wrote:
> > On Thu, Apr 28, 2011 at 11:09 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > > Bruno,
> > >
> > > On Thu, 28 Apr 2011, Thomas Gleixner wrote:
> > >> On Wed, 27 Apr 2011, Bruno PrA(C)mont wrote:
> > >> I need some sleep now, but I will try to come up with sensible
> > >> debugging tomorrow unless Paul or someone else beats me to it.
> > >
> > > can you please add the patch below and provide the /proc/sched_debug
> > > output when the problem shows up again?
> > >
> > > Thanks,
> > >
> > >        tglx
> > >
> > > ---
> > >  kernel/sched.c |    3 ---
> > >  1 file changed, 3 deletions(-)
> > >
> > > Index: linux-2.6/kernel/sched.c
> > > ===================================================================
> > > --- linux-2.6.orig/kernel/sched.c
> > > +++ linux-2.6/kernel/sched.c
> > > @@ -642,9 +642,6 @@ static void update_rq_clock(struct rq *r
> > >  {
> > >        s64 delta;
> > >
> > > -       if (rq->skip_clock_update)
> > > -               return;
> > > -
> > >        delta = sched_clock_cpu(cpu_of(rq)) - rq->clock;
> > >        rq->clock += delta;
> > >        update_rq_clock_task(rq, delta);
> > 
> > Referring to [1]?
> > 
> > - Sedat -
> > 
> > [1] http://lkml.org/lkml/2011/4/22/35
> 
> Kinda, but I suspect there is more wrong with that optimization thing
> for yet unknown reasons.

It's definitely getting in the way in the throttled to unthrottled RT
when otherwise idle case.  Removing it to test is a good idea.

	-Mike

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>