From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail190.messagelabs.com (mail190.messagelabs.com [216.82.249.51]) by kanga.kvack.org (Postfix) with ESMTP id 6259F900086 for ; Thu, 14 Apr 2011 02:32:09 -0400 (EDT) Received: by wyf19 with SMTP id 19so1502590wyf.14 for ; Wed, 13 Apr 2011 23:32:06 -0700 (PDT) Subject: Re: Regression from 2.6.36 From: Eric Dumazet In-Reply-To: <20110413222803.38e42baf.akpm@linux-foundation.org> References: <20110315132527.130FB80018F1@mail1005.cent> <20110317001519.GB18911@kroah.com> <20110407120112.E08DCA03@pobox.sk> <4D9D8FAA.9080405@suse.cz> <1302177428.3357.25.camel@edumazet-laptop> <1302178426.3357.34.camel@edumazet-laptop> <1302190586.3357.45.camel@edumazet-laptop> <20110412154906.70829d60.akpm@linux-foundation.org> <20110412183132.a854bffc.akpm@linux-foundation.org> <1302662256.2811.27.camel@edumazet-laptop> <20110413141600.28793661.akpm@linux-foundation.org> <1302747058.3549.7.camel@edumazet-laptop> <20110413222803.38e42baf.akpm@linux-foundation.org> Content-Type: text/plain; charset="UTF-8" Date: Thu, 14 Apr 2011 08:31:58 +0200 Message-ID: <1302762718.3549.229.camel@edumazet-laptop> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Changli Gao , =?ISO-8859-1?Q?Am=E9rico?= Wang , Jiri Slaby , azurIt , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Jiri Slaby , Mel Gorman Le mercredi 13 avril 2011 A 22:28 -0700, Andrew Morton a A(C)crit : > On Thu, 14 Apr 2011 04:10:58 +0200 Eric Dumazet wrote: > > > > --- a/fs/file.c~a > > > +++ a/fs/file.c > > > @@ -39,14 +39,17 @@ int sysctl_nr_open_max = 1024 * 1024; /* > > > */ > > > static DEFINE_PER_CPU(struct fdtable_defer, fdtable_defer_list); > > > > > > -static inline void *alloc_fdmem(unsigned int size) > > > +static void *alloc_fdmem(unsigned int size) > > > { > > > - void *data; > > > - > > > - data = kmalloc(size, GFP_KERNEL|__GFP_NOWARN); > > > - if (data != NULL) > > > - return data; > > > - > > > + /* > > > + * Very large allocations can stress page reclaim, so fall back to > > > + * vmalloc() if the allocation size will be considered "large" by the VM. > > > + */ > > > + if (size <= (PAGE_SIZE << PAGE_ALLOC_COSTLY_ORDER) { > > > + void *data = kmalloc(size, GFP_KERNEL|__GFP_NOWARN); > > > + if (data != NULL) > > > + return data; > > > + } > > > return vmalloc(size); > > > } > > > > > > _ > > > > > > > Acked-by: Eric Dumazet > > > > #define PAGE_ALLOC_COSTLY_ORDER 3 > > > > On x86_64, this means we try kmalloc() up to 4096 files in fdtable. > > Thanks. I added the cc:stable to the changelog. > > It'd be nice to get this tested if poss, to confrm that it actually > fixes things. > > Also, Melpoke. Azurit, could you check how many fds are opened by your apache servers ? (must be related to number of virtual hosts / acces_log / error_log files) Pick one pid from ps list ps aux | grep apache ls /proc/{pid_of_one_apache}/fd | wc -l or lsof -p { pid_of_one_apache} | tail -n 2 apache2 8501 httpadm 13w REG 104,7 2350407 3866638 /data/logs/httpd/rewrites.log apache2 8501 httpadm 14r 0000 0,10 0 263148343 eventpoll Here it's "14" Thanks -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org