From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A7F7C282DE for ; Wed, 5 Mar 2025 19:04:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3ACEC280022; Wed, 5 Mar 2025 14:04:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 33E8128001B; Wed, 5 Mar 2025 14:04:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AE4D280022; Wed, 5 Mar 2025 14:04:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E8DF828001B for ; Wed, 5 Mar 2025 14:04:33 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3B65180219 for ; Wed, 5 Mar 2025 08:25:18 +0000 (UTC) X-FDA: 83186812716.29.EE14467 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by imf17.hostedemail.com (Postfix) with ESMTP id E078740002 for ; Wed, 5 Mar 2025 08:25:15 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=IYC5s83F; arc=pass ("zohomail.com:s=zohoarc:i=1"); dmarc=pass (policy=none) header.from=collabora.com; spf=pass (imf17.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741163116; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HqK6YABSFwp1gboqFKvcbJeiOgK8OI1HggxDTa8DH08=; b=UW15BYwTbAPjvKPqWz3+ZdClrkVOn7F21+06Fqr607OpYbSArXqfXSMkP8vSKDmSYA5i2Q 9kjsW4XtrfUwcbH+V/0d0DsAxPg/EW7HmdigmEHF+p0BgInJxLmEM/OWD/pfLXb+ETsVHe gI2eoDstEGY6ZIVqpn5RYosyLRrXp3A= ARC-Authentication-Results: i=2; imf17.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=IYC5s83F; arc=pass ("zohomail.com:s=zohoarc:i=1"); dmarc=pass (policy=none) header.from=collabora.com; spf=pass (imf17.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1741163116; a=rsa-sha256; cv=pass; b=FAIq3kI6+lOTXqtw7t/334uR3Ovxfnx+3jr/GmjXzDciU1CbZyjYOVPtcAPhQ4yCJlZxP0 Mt4kujG3Rgm4HcgPd4qz/vfZnh0DE/HrCsCHPr1MogKKKnnk9eNSUi7GiXFv09r32G4r7a kMUGWdEk7+KKVS87jAtsXGc6FME1UmY= ARC-Seal: i=1; a=rsa-sha256; t=1741163106; cv=none; d=zohomail.com; s=zohoarc; b=K3xJNcfU2hs9jipz1svUwZ9VkazhJ+W4aRHFlQf898M6Z5H/KFfzsaKFbPkap3v41D1f4MtYKuuNvytrLgyBgqzf+uzJx7xa99OR9tQ3olB2u6fUm0I230EDpK/wvv3NtDCj+MyHfeMPLNWcV4y1jVDt/tWlu2+ktu4pTcmnxb0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1741163106; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=HqK6YABSFwp1gboqFKvcbJeiOgK8OI1HggxDTa8DH08=; b=MlWDrmptzUsmjSWNVtowT3Q+LLHMc1pflL/hetj7Tx55bDML3M8dZgsmWlmd+vhOVvh81+6gFXlWL9taOR7cdKmx+rJwOHE7eQPAeQv7UyaN91zZ2PpAxXdFdOJucCS3sKocaxcu3TcBSvLGSGfHP75z3mPtlSd/dz2NwlVgaN4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1741163106; s=zohomail; d=collabora.com; i=Usama.Anjum@collabora.com; h=Message-ID:Date:Date:MIME-Version:Cc:Cc:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=HqK6YABSFwp1gboqFKvcbJeiOgK8OI1HggxDTa8DH08=; b=IYC5s83FWR8MjxtXFJEziEP4iyTAkKSYIAJEu3n/yKkqPvITb+K8DHrVpbtvDjTX 2S9IQ8VSyBBvGYqj0Y2kYqbbbW+K2fGKcLmh1AxJY4JElk7nkPGhC8fRswRR4xGTVAu MiAll9E9otUITp1EeolR3SaFwNCsztilkq/Osbto= Received: by mx.zohomail.com with SMTPS id 1741163102954848.6112037464146; Wed, 5 Mar 2025 00:25:02 -0800 (PST) Message-ID: <13019f33-0882-4af3-acf6-e41c2495f78d@collabora.com> Date: Wed, 5 Mar 2025 13:25:40 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Usama.Anjum@collabora.com, Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Mateusz Guzik Subject: Re: [PATCH v3 00/10] selftests/mm: Some cleanups from trying to run them To: Brendan Jackman , Lorenzo Stoakes , Andrew Morton , Shuah Khan References: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E078740002 X-Rspam-User: X-Stat-Signature: 8ufkb4uc81tf7whcqc1ihqgjyer435zc X-HE-Tag: 1741163115-339246 X-HE-Meta: U2FsdGVkX190rvv0RrjgI27L970wsyRQsFFpGIunevNINm3/efmgjKrxCJWaFCsQcWopdYz8XRx9fL61Uud4VnBy+vY33dRrEHTzYad1pAtFPOgXOQbhBKPLKGf6OjxWsBOvVTjrvN/0s6f7zHqP27TQv+O292JM830SveX7gRhwioJ9mS+LFhtW3+7xQ20LZlRMH7bcgC3EUR/bC6mTB9ohwXfXrvplCN+pcVM6kUNFeqxY+hkS6Z4Cq3kEGHPYcyHtJIokgqOWye5BIvvf09kSHkM1/UxSXxKVU+TTm8lb7b+6R3GZ9NWObv16P/LqPhDzA4AB5c6e6/ukhq5HQKJcj/FaJjhrhFYIC9NxbwxSdI5lEfriAmsSi24l51cjyqA6tNqIhS8tuAt2vO5Q086Y0NlnDMx0OE9BJ9xK3rP7Rd2KIY7fQ6jgZGgqCjYA6dkR9wlZ9u0dYiEGpRnFhC//Aou5bwHWbipX/5d3vxN5OITKjomSADhzwIGO8CMBo5vVfA/ZpQV1rdHJoVmLjIXBBFqaC+Wfpz2vLEBpwKDxWH1ZSId/qSdH8qKefkzU7OaVTyTXU4EjYJXzVBiglHCTI2CusGGfBNiC44QRybcqSfXom5KbkKjGoA/Jgd0goN4hxJQBZ9iSQXALW85YO4rVuGLh08i8eFxc9xTAFcDWeBo2TuFpqCKMlR8r+0GthOWe3hT+/u7H8H9qeSjj2BkVidsZnlezHA1tcYVQtbr2nxISD1AS2XLAxEzZlKU+/gMj5yG+vBhZoCyHoDJqAc5LO/o7iOzKL7WIcoU4sMEN/AdEgneEgW4iXglAyZyxK97UpfGJutGZsXvVj43yz9PakJWHI1fF7HW36AW6ViGfEmVDK8eGbS4cIEI+a91SwEkt12Fk6+5305C+Ur5jEepUWDZgWxcfZA97WtjQvs8e9xCvPO389p+FQUYsQ9vYmZ5CQ5mOyafHsSdpjzX iFkjS3BC i01n4WbJL/TuGFvZ0++8xoblvptfOKsA8027pRWPTWF2FoBQPybseLrpfosovq4Z9zX/+jEAu3vVV1CyoU+UQzYPtbwDslUMvi4JqKVy5s+fVdlI9lkPvGQcNvSaOpd8Cq9Y7Mpr4Y6eW6xd91vWlxDgnSQjL6mYODagiXkOSiVxjJE4ucEFSKj+5DP8EEhNkm/m5lYW8kubNq4mOrXYHeOFqvZo48ue3Jnq78OwN0U6wJrjR2A3aBAJTcFEAl0kq7YZztGWXDziuAQ7ur4TSBN57jBBGZEs17t2Z2Z5w5EPBIBdoxxCvwpA8wIk53zDV530oWWOs2xb/Rr5SbASSwZBIBqGcQtqRNQ+ia5Xi27FPLpXIV4FSpzLUQgZxs71J0FeY0aHosozUjTPXYHGzcKZ9XpnbiAee2Ynq99QsieFroyMEwnELuozCiASuySZ6B48PXYCcHkEeDQE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.166656, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, Thanks for adding to the series Dev Jain. The series looks good. Thanks for doing such a series. It helps everyone. For the series: Reviewed-by: Muhammad Usama Anjum On 2/28/25 9:54 PM, Brendan Jackman wrote: > I never had much luck running mm selftests so I spent a few hours > digging into why. > > Looks like most of the reason is missing SKIP checks, so this series is > just adding a bunch of those that I found. I did not do anything like > all of them, just the ones I spotted in gup_longterm, gup_test, mmap, > userfaultfd and memfd_secret. > > It's a bit unfortunate to have to skip those tests when ftruncate() > fails, but I don't have time to dig deep enough into it to actually make > them pass. I have observed the issue on 9pfs and heard rumours that NFS > has a similar problem. > > I'm now able to run these test groups successfully: > > - mmap > - gup_test > - compaction > - migration > - page_frag > - userfaultfd > > Signed-off-by: Brendan Jackman > --- > Changes in v3: > - Added fix for userfaultfd tests. > - Dropped attempts to use sudo. > - Fixed garbage printf in uffd-stress. > (Added EXTRA_CFLAGS=-Werror FORCE_TARGETS=1 to my scripts to prevent > such errors happening again). > - Fixed missing newlines in ksft_test_result_skip() calls. > - Link to v2: https://lore.kernel.org/r/20250221-mm-selftests-v2-0-28c4d66383c5@google.com > > Changes in v2 (Thanks to Dev for the reviews): > - Improve and cleanup some error messages > - Add some extra SKIPs > - Fix misnaming of nr_cpus variable in uffd tests > - Link to v1: https://lore.kernel.org/r/20250220-mm-selftests-v1-0-9bbf57d64463@google.com > > --- > Brendan Jackman (10): > selftests/mm: Report errno when things fail in gup_longterm > selftests/mm: Skip uffd-stress if userfaultfd not available > selftests/mm: Skip uffd-wp-mremap if userfaultfd not available > selftests/mm/uffd: Rename nr_cpus -> nr_threads > selftests/mm: Print some details when uffd-stress gets bad params > selftests/mm: Don't fail uffd-stress if too many CPUs > selftests/mm: Skip map_populate on weird filesystems > selftests/mm: Skip gup_longerm tests on weird filesystems > selftests/mm: Drop unnecessary sudo usage > selftests/mm: Ensure uffd-wp-mremap gets pages of each size > > tools/testing/selftests/mm/gup_longterm.c | 45 ++++++++++++++++++---------- > tools/testing/selftests/mm/map_populate.c | 7 +++++ > tools/testing/selftests/mm/run_vmtests.sh | 25 ++++++++++++++-- > tools/testing/selftests/mm/uffd-common.c | 8 ++--- > tools/testing/selftests/mm/uffd-common.h | 2 +- > tools/testing/selftests/mm/uffd-stress.c | 42 ++++++++++++++++---------- > tools/testing/selftests/mm/uffd-unit-tests.c | 2 +- > tools/testing/selftests/mm/uffd-wp-mremap.c | 5 +++- > 8 files changed, 95 insertions(+), 41 deletions(-) > --- > base-commit: 76544811c850a1f4c055aa182b513b7a843868ea > change-id: 20250220-mm-selftests-2d7d0542face > > Best regards, -- BR, Muhammad Usama Anjum