From: Eric Dumazet <eric.dumazet@gmail.com>
To: Matt Mackall <mpm@selenic.com>
Cc: Hugh Dickins <hughd@google.com>,
George Spelvin <linux@horizon.com>,
penberg@cs.helsinki.fi, herbert@gondor.hengli.com.au,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] drivers/random: Cache align ip_random better
Date: Wed, 16 Mar 2011 20:26:33 +0100 [thread overview]
Message-ID: <1300303593.3202.30.camel@edumazet-laptop> (raw)
In-Reply-To: <1300299787.3128.495.camel@calx>
> I think this alignment exists to minimize the number of cacheline
> bounces on SMP as this can be a pretty hot structure in the network
> stack. It could probably benefit from a per-cpu treatment.
>
Well, this is a mostly read area of memory, dirtied every 5 minutes.
Compare this to 'jiffies' for example ;)
What could be done is to embed 'ip_cnt' inside ip_keydata[0] for
example, to avoid wasting a cache line for one bit ;)
c1606c40 b ip_cnt
<hole>
c1606c80 b ip_keydata
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-03-16 19:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 0:20 George Spelvin
2011-03-16 2:54 ` Matt Mackall
2011-03-16 6:24 ` Pekka Enberg
2011-03-16 17:17 ` Hugh Dickins
2011-03-16 18:10 ` George Spelvin
2011-03-16 18:42 ` Hugh Dickins
2011-03-16 19:45 ` George Spelvin
2011-03-22 9:03 ` Herbert Xu
2011-03-16 18:23 ` Matt Mackall
2011-03-16 19:26 ` Eric Dumazet [this message]
2011-03-16 19:55 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300303593.3202.30.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=herbert@gondor.hengli.com.au \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@horizon.com \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox