From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96746C43334 for ; Tue, 14 Jun 2022 07:20:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 361678D0216; Tue, 14 Jun 2022 03:20:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 311846B00ED; Tue, 14 Jun 2022 03:20:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DA2B8D0216; Tue, 14 Jun 2022 03:20:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0E16A6B00E9 for ; Tue, 14 Jun 2022 03:20:53 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DC70C21472 for ; Tue, 14 Jun 2022 07:20:52 +0000 (UTC) X-FDA: 79575994344.02.0462742 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by imf20.hostedemail.com (Postfix) with ESMTP id 4EC301C0085 for ; Tue, 14 Jun 2022 07:20:52 +0000 (UTC) Received: by mail-pj1-f54.google.com with SMTP id k5-20020a17090a404500b001e8875e6242so8251022pjg.5 for ; Tue, 14 Jun 2022 00:20:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=x3VzGr/fSHQypY+i+ztObznAHCuT0co5thLO7MdpFL0=; b=zzQhFHJOXlSKySb9yp1KQ1ub6zLwe6JGFCECrYPIUu1EJieVGCVAnZqJJ8aqUBwTMK WwiuS+k6jzu2XtIPtpM5WDZ/oKx7GWoEAVYHv3emsjnt+5071h4zc5znKs7MFr6wDE2b TYyH+tQcrA3/9VIkrQVhK3WVpdAP4q5tGyPZ0H08doT/RAbCrurW25CDX9dFydpMxB+y SUtNvsDCaf5HBgLl6pZsR+frFFzH8C51yXJo2ogUwpT43PTNU8kMtKDmCoKixBxxdIHO 9aWtob3CUmV40bFtrxj2m9m930RV6lTcD2n2Hq9CF4f+WhYukD+LFj2tS8C8rcPqIjCc le0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=x3VzGr/fSHQypY+i+ztObznAHCuT0co5thLO7MdpFL0=; b=q5F6mwtXMMDCSQ1HPxPu3ze9Co3foPbmMyH3ery5AQ7zbOtqULasv++AmwKlgKN7P+ 9cYaEiP/uHc2FbFme7+XD9HPhrCaXeQoMeMlIZMcyTN/qdhMyBHPzONtLWNajdMzvhPC /SLet7s+uetzEKxK/IJS4zIyeu0j4CttsUTo4FvvERs1v+NxVJQ1HG4Pt7wjJeMHdkVj iHlOjbG/2SXyiFGC01hK1S2XTH1afjDd5Q0ieovq1CqRK3m2p2gqg3Ygm+MxR73l2j1L RgbiTGPiFKL654JaBSFP9UZhLSH1eMuUflbp+xkT6KPgzENrHCdR3uRhEuLmu8Hyga1y 49nQ== X-Gm-Message-State: AJIora/z8i66X+vx5AZhz5hKa/c1mj4e5IVdoRnmQAoA2xUak6mDQXQz u2otM0TK5sgSyzJ1gICzs59AiQ== X-Google-Smtp-Source: AGRyM1tupFfevnhvE3qrqzeChNwFv1DJYZzyH0DgykcokUf98ZLv9a17HvvfC58GfIOeq4lT/zsgaw== X-Received: by 2002:a17:90a:d104:b0:1ea:b84b:a084 with SMTP id l4-20020a17090ad10400b001eab84ba084mr3068817pju.95.1655191251044; Tue, 14 Jun 2022 00:20:51 -0700 (PDT) Received: from [10.4.36.16] ([139.177.225.255]) by smtp.gmail.com with ESMTPSA id jj18-20020a170903049200b00163f36005e1sm6383907plb.42.2022.06.14.00.20.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jun 2022 00:20:50 -0700 (PDT) Message-ID: <13002894-edde-3163-f56b-d344147293d7@bytedance.com> Date: Tue, 14 Jun 2022 15:23:12 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [External] Re: [PATCH v4 1/2] mm/memory-failure: introduce "hwpoisoned-pages" entry Content-Language: en-US To: David Hildenbrand , =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= Cc: "akpm@linux-foundation.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "linmiaohe@huawei.com" References: <20220614043830.99607-1-pizhenwei@bytedance.com> <20220614043830.99607-2-pizhenwei@bytedance.com> <20220614070934.GA1627546@hori.linux.bs1.fc.nec.co.jp> <66c43dac-32ac-5801-c76c-01607d68e38b@redhat.com> From: zhenwei pi In-Reply-To: <66c43dac-32ac-5801-c76c-01607d68e38b@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=zzQhFHJO; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf20.hostedemail.com: domain of pizhenwei@bytedance.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=pizhenwei@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655191252; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x3VzGr/fSHQypY+i+ztObznAHCuT0co5thLO7MdpFL0=; b=JRHTznIampRPFizzzpYM2obL5eEy8QpDke2MpQg5HoOjs4ZN53okF5k+T+LNiV4c3r388k 11wxrGjJdKqtlMYfcCLNd4kvWCcPQRzwNoN9agjQuy5UFqjIBY14a7Fk7eW8h099A45mzC +BuZTA77XFaAtdfoLvxl11yztQRu+ZQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655191252; a=rsa-sha256; cv=none; b=wX/O79RMyh4cdOW7WtwidY3wcIJ+3eT9eeHEd75jtVZKMRtmpCt7UTctFthwueFDW6kptu s72xQUcINkAD0CHcEHrPk2n3dF9QQiBjlz5ZJHl9n75wC3SHsGIJvoRP7okXnsEGngx3L8 p/2fRmxqS3+2hqyadJ6W7zoE38mP+No= X-Stat-Signature: 8fakmzjettk78jf8cjuopdqdtbuxhgtj X-Rspamd-Queue-Id: 4EC301C0085 X-Rspam-User: Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=zzQhFHJO; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf20.hostedemail.com: domain of pizhenwei@bytedance.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=pizhenwei@bytedance.com X-Rspamd-Server: rspam10 X-HE-Tag: 1655191252-707147 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/14/22 15:13, David Hildenbrand wrote: > &hwpoisoned_pages); >> >> I'm not sure how useful this interface from userspace (controlling test process >> with this?). Do we really need to expose this to userspace? >> >> >> TBH I feel that another approach like below is more desirable: >> >> - define a new flag in "enum mf_flags" (for example named MF_SW_SIMULATED), >> - set the flag when calling memory_failure() from the three callers >> mentioned above, >> - define a global variable (typed bool) in mm/memory_failure.c_to show that >> the system has experienced a real hardware memory error events. >> - once memory_failure() is called without MF_SW_SIMULATED, the new global >> bool variable is set, and afterward unpoison_memory always fails with >> -EOPNOTSUPP. > > Exactly what I had in mind. > Sure, I'll send a new version later! Thanks! -- zhenwei pi