From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6760C2BD09 for ; Mon, 24 Jun 2024 13:06:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 506AB6B009D; Mon, 24 Jun 2024 09:06:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48E0B6B00A6; Mon, 24 Jun 2024 09:06:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E1196B00BA; Mon, 24 Jun 2024 09:06:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0B5196B009D for ; Mon, 24 Jun 2024 09:06:11 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7DDE8140EF5 for ; Mon, 24 Jun 2024 13:06:10 +0000 (UTC) X-FDA: 82265805300.17.438C2AE Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by imf30.hostedemail.com (Postfix) with ESMTP id 81CE280014 for ; Mon, 24 Jun 2024 13:06:07 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="GcC/bQEF"; spf=pass (imf30.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719234354; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vjbtUbH0/r3ewxHlL2R0EHYshkh/JTAG0D1DEhiQckM=; b=hq+wXHZUEfvDxXwRn+tyKmbtJbNnoIzrG6TXH8jGq02167m2HNLXgVLqNFG1xQxs3TwvnR VGiq/H7GX2I6RtVC5ldNbuJISbihMdz1B0G+L72xgkIHcgbulbg2nww2jii5QJoV+ir0mg AH9CdYoRSy/VDU0wUjkgcOrukEYR9/g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719234354; a=rsa-sha256; cv=none; b=FgpC4OSWvoAnDT4vmpv1sBH7g88gEg3WMQf/hyDwr4UEJh0wrv40AypTrbZUQW3Jyjdq8N c4w3bruT1RN6Gim8XVVUKQvkR6m0otZnsI4TcFPeaiqdhETpJzs3j2jf0uK1J/r5ntiYn6 ETmtlGhcdgc/UFVKTJ6RsOd7mFMAYXE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="GcC/bQEF"; spf=pass (imf30.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-421cd1e5f93so32854035e9.0 for ; Mon, 24 Jun 2024 06:06:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719234366; x=1719839166; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vjbtUbH0/r3ewxHlL2R0EHYshkh/JTAG0D1DEhiQckM=; b=GcC/bQEFiVhMyoHxAg/oG70EgXSTUP6j6N38TpafKK+zCRrVxikWyZ/W2KlVFknn5I +TOTfw7wzaCXuM9P8KUyOfTkrbCNVNhNg4ff4L8ML/kgeCIy0Z3Yb9mvMnEgTzJwGWlk wlbfJm9C4vZocZbdso5ny/M5le57QgO9W3f3mZH4iEAu6b+2ShWjM/H4FDlK8Pr4+5pW aghRRZlgSZRVP9tlABCEeUgxvzGdICkR3VczRbCsCcb5ue4VBAeuAr4ibLAHcLrnAgvz nm3Z+wmzAtAeczzpfbR21MQdC6mq4oJ2WCoiYcAe88SHUeVhB0PXuAsRkbIdpaoaj7cR 3m2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719234366; x=1719839166; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vjbtUbH0/r3ewxHlL2R0EHYshkh/JTAG0D1DEhiQckM=; b=AOrICy9Hn3vHWKB4U1IzBR1eKnTR3M4ymf9AVcWXrRB6vDFpQ3oiBsXap7tLjp9K2M NNizdw/tSp90c6fIFbUidcJRetani3Nupppjj040Z8++k0inpO2mPh4qteIx4st6O0/H srcmk8TSl4LewZCthNVayvMZCxmfjWtDbtlYK7ZCNLPBP5m+hal7Y9K2rFTownaKSgya ZX7jWpc3fZsRE+qS7J9WEjEimwP71tliJus0GuDXiMQyUeN/elKbo3EZW6TlIqhkLkNT DlZ7fshGjWKURlOkhF+Hlvx9oH9FHcs4mQYwmV2mrJmS8ByWv3es/rAgD5yVavHpJnNc obLg== X-Forwarded-Encrypted: i=1; AJvYcCWcZzUfjogPhA1N735Gd07kVzdLAy+C8HDZcORhlldxGsRUh5cN3EaO1oB47dK7auHrD3KuQC3lno9yBd4HvvfXnyA= X-Gm-Message-State: AOJu0YwUU6RND6sWgDMQg85GjuVzUaKtbRmHQnBAfGlW6CXrcd2iiEcQ 241VwUwLdCqs0GH1kWX0wtyAdHtJShaqXRHBsK1dbApyY9b0dT1p X-Google-Smtp-Source: AGHT+IE4FlgLAOGpHUN4Wucv93B2eDrXC3YiiP6yeuDXARAnrn5UUyqDVlY4M0LXfHpTkpcZ0nyEuw== X-Received: by 2002:a05:6000:1816:b0:366:f6bd:a549 with SMTP id ffacd0b85a97d-366f6bda769mr1544909f8f.11.1719234365512; Mon, 24 Jun 2024 06:06:05 -0700 (PDT) Received: from ?IPV6:2001:16a2:df66:b900:46d:aa3:6645:bcd8? ([2001:16a2:df66:b900:46d:aa3:6645:bcd8]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-366383f6355sm9968296f8f.17.2024.06.24.06.06.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jun 2024 06:06:05 -0700 (PDT) Message-ID: <12fb19d1-3e57-4880-be59-0e83cdc4b7f1@gmail.com> Date: Mon, 24 Jun 2024 16:06:02 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linux-next:master] [mm] 0fa2857d23: WARNING:at_mm/page_alloc.c:#__alloc_pages_noprof To: Yosry Ahmed , kernel test robot Cc: oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Andrew Morton , Chengming Zhou , Nhat Pham , David Hildenbrand , "Huang, Ying" , Hugh Dickins , Johannes Weiner , Matthew Wilcox , Shakeel Butt , Andi Kleen , linux-kernel@vger.kernel.org References: <202406241651.963e3e78-oliver.sang@intel.com> Content-Language: en-US From: Usama Arif In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 81CE280014 X-Stat-Signature: wpniannrzostw3rpsb18fxb5cnoqcw91 X-HE-Tag: 1719234367-791422 X-HE-Meta: U2FsdGVkX19G9NxpVJ2CPZ4F0Lkul/txuCwZiCpASJeY8a+b03FJ1e+MpksERMqeTcYK2VUtFJS17JvrgM8D4t/sgTQNM/t6nj9fuisby0zUWYgEwAp1DCwPp34/pqBAqYJ7DyKBi2ll/Q7OIosLgRe1bOavLPoHx7/Oj4mqbAwWwjYJJes3O2YMQOFNI2F7P5AfKUv+VZK/cZnMaM+YKkMk+VcUBxCEb+mtvIz4EGA3iSTmdVQRhe8YOmrq7mpaSzlYAxnV7XLGvnWGOpzYdgPvN6mlg8sPZOS01A+yI1eOkPRAHnMgvuvfvNZqcZUSmlPV7kyOVMvtH/NLlxgbhDLecfoRS/nRTsPoEd68Oug7UL5HVHOrbOFBXh5Ca+NEY/p36HNkAc0ycGp82L7A571jqlx0SAmRMcbLy94ca3efLe3Sfma2FTpD965ymWT54kE/nxoeMYVHrkfuihS0y9Woe2o4fAg8cid1cuew8ML5fgFcKN73/torR8GK3ia55SGicRQgvuQIDQC/dEk0fPpW6rTm9nCt5VJ8VQslWqrT1jKxbcOPqf/uCzBmy684VGBItwdSEcefcqmq7j7GItWXuvzokPzgIGmI6RK62n3b6qRKjYYHQd9WJn59vYb/ZTDaL9UjmARl2cTulvYNidc3hmGSpm3uwsfF7mQoxvnQNji9Q6+qPOjF65j06uOfXVbjuTLM6D87WRxycEXCZqTzXdAh7l3a8f3DFvIlov3bVdGOx0OxVruHMe3WslgEbieQY+DoJ0XJLcR03UkKWkh2PTdp8GCodKoPHMnXuuwLttYZQ+YoQBl9F0izMswadiIMFgimXTie2pOQYjXfb4kgWcZ9QU4Y6L8biYC3PpS4jS+vIIZimWGFmnkH7S54634aOQ916h3oXrr1Yljh1dcpuXz28RF0j/YIebF23p6r0K64o2p3uAFZfBmRNJ1CcNLGp1kd74w1A0uTZ1R sLpHz76F qLktr/7AKWr1gfEVQ4fCRLGrV+sC+t7MWJOHOFusgyQIIhXzHwf7mZhkuBOgLUyPE7VLj2CObta4suGmRGTNYOI9PUwA+otQI7F7x3lAURuX3941SW75feruzBAShw0XOiwo+WyGTotEzmRk2VLjbULsujzMKmid0/5Q7kOF67hs0BYe0HV7FfmYunjK1veZ9Kg8Gcfq33HTa71Wz7Pkz4kGSthMAu8eQSnjkcht6xNtbfGmCCBz3RqozHyyGPQ+2mRJocsRfkUHsSiD7nWANP+vWuzemE3Fg9moglzkTFyLzRwNX52MV82v5fC+eK5n5smcptMbThy3qYLrI2UEW6/4NhfB8oqatqV63oAVpIvyEbbL6WPk0TbLHIurN12YmIANDAhcakl2ixaT4L+sdihhXDDy7CO5cB9mlGgY3oBT3MXhNzzx5CmW5oO/dqwi18snvP/DlTnU2rJpwq/PNY8JICEZmF5mg1J2OEIdAwZSRAFuFnpK2yAggJYvYdY752QIRiveD/LL97oUkxzkdlHLGtZpPSo2YbJEMdUzhGXj39UwXnA/+Ndi/zE3/zNQ+Z7aI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24/06/2024 15:05, Yosry Ahmed wrote: > On Mon, Jun 24, 2024 at 1:49 AM kernel test robot wrote: >> >> >> Hello, >> >> kernel test robot noticed "WARNING:at_mm/page_alloc.c:#__alloc_pages_noprof" on: >> >> commit: 0fa2857d23aa170e5e28d13c467b303b0065aad8 ("mm: store zero pages to be swapped out in a bitmap") >> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master > This is coming from WARN_ON_ONCE_GFP(order > MAX_PAGE_ORDER, gfp), and > is triggered by the new bitmap_zalloc() call in the swapon path. For a > sufficiently large swapfile, bitmap_zalloc() (which uses kmalloc() > under the hood) cannot be used to allocate the bitmap. > > Usama, I think we want to use a variant of kvmalloc() here. Yes, just testing with below diff now. The patch is not in mm-stable yet, so will just send another revision with below diff included. Thanks! diff --git a/mm/swapfile.c b/mm/swapfile.c index 0b8270359bcf..2263f71baa31 100644 --- a/mm/swapfile.c +++ b/mm/swapfile.c @@ -2643,7 +2643,7 @@ SYSCALL_DEFINE1(swapoff, const char __user *, specialfile)         free_percpu(p->cluster_next_cpu);         p->cluster_next_cpu = NULL;         vfree(swap_map); -       bitmap_free(p->zeromap); +       kvfree(p->zeromap);         kvfree(cluster_info);         /* Destroy swap account information */         swap_cgroup_swapoff(p->type); @@ -3170,7 +3170,7 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags)                 goto bad_swap_unlock_inode;         } -       p->zeromap = bitmap_zalloc(maxpages, GFP_KERNEL); +       p->zeromap = kvzalloc(DIV_ROUND_UP(maxpages, 8), GFP_KERNEL);         if (!p->zeromap) {                 error = -ENOMEM;                 goto bad_swap_unlock_inode;