From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 311E3C6FD1D for ; Fri, 17 Mar 2023 06:34:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9504B900006; Fri, 17 Mar 2023 02:34:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FFE6900002; Fri, 17 Mar 2023 02:34:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7524B900006; Fri, 17 Mar 2023 02:34:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 624E1900002 for ; Fri, 17 Mar 2023 02:34:06 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E633814171E for ; Fri, 17 Mar 2023 06:34:05 +0000 (UTC) X-FDA: 80577425250.15.B99B773 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf27.hostedemail.com (Postfix) with ESMTP id 62AA54001B for ; Fri, 17 Mar 2023 06:34:01 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ddTJJsv+; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf27.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679034842; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QnHtt/MwzW2Sr8G2cOS9gx9BQ+7ygIJAkg6NilJ8JHw=; b=hbubwqAtOlBIGRL/BmnlfvrYnHQbJ7Jtfm4d1TJuCDOS3oy1kDUmUDqMgAQe5/y8XmBID3 ge8KteuRm+kNQMbEn3UBAO7rNBSDuk5pH5mLJzeFNoisxqsxw71uZ/GjE8AsekIeabEh1d VLEefTifUb4aa42Yym3zsnF7VbVQTfc= ARC-Authentication-Results: i=2; imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ddTJJsv+; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf27.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1679034842; a=rsa-sha256; cv=fail; b=f5J32TS835yz9XHgq7yC1RpOKNEa9p3jgV3nVd57HQ/3fYM6DiLD4teb42CUAbQNSRLTcw wBvupDyM3lkwnuyaroU3W6Q5XvnwB7/L6UQyg8Gs0VZWHxB8EN/scjEYID6umhBtZOoKr9 gOqjiTWbym6GaX6mLvQ5h5CGO2zkwFU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679034841; x=1710570841; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=pQNHJcVf/uqPXf6On3XrFhV0RhjTK2mejPRv9V1OOPE=; b=ddTJJsv+ia3CUZ8WWqPScWc5Lo8Xt3QKX1LaZAtLOHChYdXK6JZcB91b gaNdN7F0TZptIoP6SampYQgwVHx0hiexUK0eL5Iqs2TC+YvCDEaYtN1gS I70USnOmwtb+gAl7TxVHRKBNid9sbc8PAgw7xu0/rlrBCd0I1KGew0L2s dPIu3AF3HwTou0s/1ug2RJHFkNers1g9bcNvq9IPazWendvjnkgam+ekk FO3gMEWV8rhDevyxHzyEjDlXVFSpHPtCCXVAaayVh7dfVOVRybWKI6BVq 8GRZ7bia007l/45ZHSIcqsw5b9ziqPAMErh1ygievLc2kWCV8OIggAZFz Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10651"; a="326558076" X-IronPort-AV: E=Sophos;i="5.98,268,1673942400"; d="scan'208";a="326558076" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2023 23:33:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10651"; a="1009527341" X-IronPort-AV: E=Sophos;i="5.98,268,1673942400"; d="scan'208";a="1009527341" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 16 Mar 2023 23:33:58 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 16 Mar 2023 23:33:58 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Thu, 16 Mar 2023 23:33:58 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Thu, 16 Mar 2023 23:33:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a6Q6fxyh+3zuYpFNPEk0Umjzb88E1HW6xxd3BfJVQts8ermNytVZDaARElZyZzUIDJCf40yi8JCUQcFH3qFifKQvvJrla1hSclpcNyTURraXk8isQ62uVgUrat0G1lyRC8iUUdTUBJyxXTiOz9DRBCqZ7ZENbXxT34lgstd4zuFpP2jzzpY2Kj5HPKUJnUqolj3LF2YBhl8mgfak8IImvKKE3SauhGQ6xONnUXceQu1RTfeAc3lZCSv37YvDpSTB3hnZOc3n9g9OWt+bWHgWI5Mq+pBTZpLlcB6/uYrPAEHc5yW0nYfjifalwIXKIFfJ8FgX2n1jQfDFBhzHDuJQow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QnHtt/MwzW2Sr8G2cOS9gx9BQ+7ygIJAkg6NilJ8JHw=; b=B1QkmEb42p4a91OXf003IrPWQ71cp032lrM4DvnqJsulAsFwixhz/LtZ5pACYR7u8lVyK6xU3ZTdrS+didhkCx3uYMk4cQqsNxJon6flUhFwGsBWbUICFgS3Y61fsg2d5H+K7UJtkwt4SL+wyrXshLF99usY9ot/ceZUy9SHJIH9B8bMKSyJpdUFM0lCqq8HytQ0kE3n2Ueigj4QLc5HF94p/3hItK1WtJz6o1oY3z1vHIKvKU59ByzRFp1EaNQ8ktViezl4gE3HCS5k0vDKj3V6nQvdADGC/6JQfz4maew7icW3UflGF8b8pBhMtPseVQmFFncAUaumTNNHFYHyQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by BL1PR11MB5416.namprd11.prod.outlook.com (2603:10b6:208:319::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.35; Fri, 17 Mar 2023 06:33:56 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::8073:f55d:5f64:7c6]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::8073:f55d:5f64:7c6%8]) with mapi id 15.20.6178.026; Fri, 17 Mar 2023 06:33:56 +0000 Message-ID: <12d7564f-5b33-bdcc-1a06-504ad8487aca@intel.com> Date: Fri, 17 Mar 2023 14:33:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.8.0 Subject: Re: [PATCH v4 35/36] mm: Convert do_set_pte() to set_pte_range() Content-Language: en-US To: Matthew Wilcox CC: Ryan Roberts , , , , References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-36-willy@infradead.org> <6dd5cdf8-400e-8378-22be-994f0ada5cc2@arm.com> <2fa5a911-8432-2fce-c6e1-de4e592219d8@arm.com> From: "Yin, Fengwei" In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR01CA0151.apcprd01.prod.exchangelabs.com (2603:1096:4:8f::31) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4820:EE_|BL1PR11MB5416:EE_ X-MS-Office365-Filtering-Correlation-Id: f38f76fc-e1bb-45c9-aac7-08db26b1955b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yGJ9ZF5yH/ALWHROtHRO0EROpobWXXiVbtft4rhw8AP3MhV8RCvhL8bsSjnu6s0R+XAypYXxfwTTgqL1ZxDL4/Z1EajQSh2BVSBA4Sk9KXp70oIoqYyPV+G8Cz8Jtx/xmyGiY/5RYoPa8WCVhJ+jco3gehSni7fZfXp3kOmj/pCWpHa9RpMQl0nX8v0Dq74aLyv2lP0g1cRWmL/O60m/F3grZkCG/lqkV+Gw7Pgxxsbh2xudip3K62YaDJf2JC4ntCqq1Khw0FuKdedI1GhcFGWTKuQocbmgj0Ev/t+WdSzXW/FOsPiodcXUlFEvS2YlwFtToJBQgYDxflir0ljn0HceMtdTsXxK2ydN6Z9jGb6+71OmFFOrRXizAXndoJTpkNM3pX97TKOsrD1DD74/wlyEFFceJXQCbS/SsBxbGHAAmdGCJetrwfX3FZ6qURQrLK+6KFPg845PRrK6fMf7RPiYzkEAtekwhZ3OgUeNV9/foJk44G1oN3ltPotlAIKds3VYTVsuZ1sSmu/Z7cPnATMMqDcsNzuQkl+6sRyr+mk+bxjGNroCi9LQX12DpMnul5GfmqHh7LhIo60Fr5vf0DRpNVk57Xzmb/EXpqOAiC0z1vyPba+0aBmD/1NSueAKX/HfEKpaiz8uAS5QAjJPXpmld7Zi78Rpuy91S7VWfg7ZDZrQ3Jdk1ZtwDdLTMyMCFyrht03gP/1zKgx83l0P2XD+80ecltuzTSJOuUUP4C4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(396003)(366004)(39860400002)(136003)(346002)(451199018)(8936002)(5660300002)(41300700001)(6916009)(4326008)(31696002)(86362001)(36756003)(38100700002)(2906002)(82960400001)(6486002)(6666004)(83380400001)(478600001)(186003)(2616005)(26005)(6506007)(6512007)(31686004)(53546011)(66556008)(66476007)(66946007)(8676002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3dWYm1iYWdvNjR6dHFsK3BqSEdRZ0xBaXRBQ2RYV21mMjA5VkpxclhJWTM5?= =?utf-8?B?QWN5UEMxZHNGbmF4S2VDeGZwUWFOOWFMcVNVaGhrT1kxMVExSTVRV1U0T2ZU?= =?utf-8?B?Q2gwR1JadVFQbDh1SDByQjZiZG5UV0dWOWEvK2ZrS0h3emFCSTBDWVc0UGxh?= =?utf-8?B?ZEEwSHB5ZUNSOWFEbW9vTHo4VkJWZGFaZmpmYXN6WkFTcTJoeHRjaW96bjQ0?= =?utf-8?B?NGxnV1ZLTUJyMkNPYy9UdHZ3MkRBV0ZoemVod251cU9oaE4yQnhhMGJUV1Mx?= =?utf-8?B?V0hzUmpsMVorWkxmdytYbWNjY1owU20xSTltOHdkQXV4L1FpSzNKRmdOWHFZ?= =?utf-8?B?S2RGSWh2a3UvL284TldMWHJ0RmF6RHY4MHZVSzduTXdFVmJLaTh3L1Uyd1Zt?= =?utf-8?B?YzFUQUJEbU93MVFvVHZBNms2RUd1SkFqeGN0WEowRU44NjEvaVYveHhjV1d0?= =?utf-8?B?U0NscTVYMFRBZnlIc0txTmlYcUxVdzVlcE9LaFF6d2FnOUdBaVI4MkgrN1dQ?= =?utf-8?B?UzE3RFdFTm5NYTJzUDBSQjdQSk80bzRRWWRBQlhkOXhEQjF4V1NpWXRGakJS?= =?utf-8?B?U0wrT3MxNk9TMm1YOTdXZ0hmcG5MdkxQWGc5VWdDQ1lBaFFKSkZPeXB3RHlF?= =?utf-8?B?ZGppOXl0VGFQemxCQ0ZjRkpTR0VTWnVZRUpnRDF6MnpxZTRUbTcvRWQ0cUlv?= =?utf-8?B?SkVaVE9wOUl0eXhXeGlJanlXYzJIUm1NSUE2VkZOb1M5K2wxck1oMVZyZkI4?= =?utf-8?B?ZURYWW0rYmtXb1g3d0JkbFRFRFNDRi9DRHBwd0NFZDdxb1Qydk1SMlVZeTNp?= =?utf-8?B?L3NZaWtvWUR1NnE2R2lKdEwwWVJlUHlvRWQ5TSt5aEg1SGR1VmZ0Zm5sVVFp?= =?utf-8?B?dkRDaVhJeUMwNml2ZmlYNHBEQjhXSS9GK3Vacm1JczFSV3hjTXl0ei9FQlJU?= =?utf-8?B?Rnl0Y3FzM29mVXRwcFpsK1c2aFdXMlNmd3lhV0Q3YitxNjI0WXBzd3lrd2w1?= =?utf-8?B?UUVkdXlocnEwZUR6clhId0VEdHZSTU1YSU0zU3VrNlJVMmdEUlhYNWZvV0Va?= =?utf-8?B?bmpQallvSlRpMW9ES1lpa3FXNDVoWVNoa3FhcXhOVUVqTTQ0WVhlK004YVVF?= =?utf-8?B?dzBtYjF1QW56SWkrRkhYUmd1Z1F2UVR6YnhPbTJPOUxGOElCVzF4QkRDRlhG?= =?utf-8?B?QVlyWUl4QWowVU85a3JzTC9DTzhkckVrTk5UeXlIc3BHd3RjOVplUUErcmpR?= =?utf-8?B?aU9DRytObEJxZnUvQUUrZzNJdnVRUnlxTDRKMXBpU2lLOVZGOHlvOHk2M2la?= =?utf-8?B?MGZXbXNSYmsvdTdZcGl6SlExZTdHUXI3bTU5VmZGT3lWMGdzNldTR01kTVFw?= =?utf-8?B?OWpTUDV5WjVEYjlDZWYwbjhjUzUwenlBUjNONk5ncUVaUXBZSnhqZTMycXJP?= =?utf-8?B?ZVkxMzlyZnZuLzUrVEM1SnpSTVhmbWhaSjQrQkhQcDltUmZIZ2lPd0I1UnBl?= =?utf-8?B?MnFsdUZmK0t3VGpWMTdyc0xCcWlnMEwyL0hWSWVPZ2k5TXE4ckVVMGhUM0FO?= =?utf-8?B?MWJ3WG9hZEZtNjk0UnUzT3h4ZjZQdGpldlZ4cnk1NEpNU3RwSStjRHhhS1pP?= =?utf-8?B?Y0o5Y0RBTnMwRXgxVDdTN2d3SVRXQkhPM2YvSzJzSFVPZFJWK3l1WGFrZHZV?= =?utf-8?B?U3VtckNvVi9oUlZkRmJhL2I1T2xpUGw2VU1ZYWFVclMxU3pBZENNelpvVmxn?= =?utf-8?B?TUNtRVg1NXdZZVBvejZNWU91WndyeUM2UXY5MmdiSlBIR25qakltaURZSzNz?= =?utf-8?B?U0JKSHZLc05TRXFSRkNNbnEyMmhrT0dUL0Fyd01pQXVKWXhCeWJKUWkrOGk1?= =?utf-8?B?L1crdFZ6S0F4cmdaKzlDS3F2eVFxd25uckxhNzF1bXIzZXo5UmpkaVB0V282?= =?utf-8?B?YmJzUTNHQ0c1VlA5VnRIdlpZMUtrcG5ZUXhNTzVqTm1WdlNtSThkQ2JId2RR?= =?utf-8?B?U1dIWWdvcGJ4M1UyVWw1cDVSWEZZUDZDRDl1QUxyc2ozakZQVzVkQkNmbGxI?= =?utf-8?B?ZDZvV2g5RlRwT0tmZFl3OFZ4R3BRelc0WDhrUDc0Y1AvaytaK05zVHp2dWY5?= =?utf-8?B?U3FocWpZMERONUxaNUJTQjg1TnZlbGIvamV3Wi9MWFh2M3M1TWV3bHpHbW43?= =?utf-8?B?Vmc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: f38f76fc-e1bb-45c9-aac7-08db26b1955b X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2023 06:33:56.1655 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gmp5TLJefBBN8nVEAD/NWNJwuUj3D+xg9mR1CmiDelEsMVbSTsrl+o79CRshlulodtDVlFxoig4tbGMprndy8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5416 X-OriginatorOrg: intel.com X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 62AA54001B X-Rspam-User: X-Stat-Signature: u7oqqaf7nbdt8ytiydz3pbf6eowi6etf X-HE-Tag: 1679034841-803092 X-HE-Meta: U2FsdGVkX1/hsKjbZaqgLnHwzL8VXHcXHzIDgIagDPusSLzFN1vLMhBzBFVJJvU/y7qrGcptDQNS6qFRDEce9u2OI1650AqGx7uX0lHGBxXvFKxSmNwJNntVDfZxVtleyMEDK0Bn9Q9PS2QZZCkkaQuX+ql3gZYZ1uQcSuT2k9r1b0wGaGLzS94F/xtwwmrbA4gUdaVpjnhDlRh+sqrteKLWUmTKtzx5k+GyztSCJe2Z03pkbYlOg9eumRverBB+7rh1QdjibFG+ZQpmswgU3lBaCPHGkH98RBegPHyIiEEkTmqpfd7yYQUD8y7E7nh1BlMl30tV3BjyAEUZHftK/KkGUF9f4tcqt2S+QRQyr5UKf8YXT9LCbEinuRpFtUGTwcLDWapBaUbDkDA9GODg7AGVfD/dqwAvlTlFxuYwT7YGLBlFzVSnmFAeh6HeHFiWg4D3lwH0Ma4vu9+5XbJTPoyWLQnVVBD9ztgWiATnbwyxI+aE7XVPl9x2Pym0n3FTqJuwIOFUfITWpPNX4CfCYmVm5uj7BzsTse4zClDCyPkWtPcnxUFnn1TTYBsBUySuFOKHNiee/YK0w63X8PXH6IYp0DX/vlANqy02S500MxOa9BxhHQV7lYdW36MXsvbEn535fLHtytYuenGYf87oNvtIBac8hGmaedNe/EkOc9C6a6xL6SsJisWpJueHrIJRtdatZXd7kfU65AOtHkaDk4Z0kNjTpAJ7xIAGz2bgGLQBe7AfcKi6RopfeSfG8cEdjFTWk7a9QBVNLkB7GP6dRyGSvWHcBWUL6dsclxXzmo9UIhordh0VW8WxY8hjwrahoVJG7+Q75oQ+KqHS0B/nGJWYW2jIX67n1Stv+NwJZW66GztobB7hF1yzT24gTWzVGgw38dCPwRFHqYuXEmZgclMZ1hW8Gkg2yu7m4EphIzIJRQBr14Tn68PeEskUHW9GIfMr5lB/queCkeKXYEH z0z7otNd rS3cqeeELajWRYxRtkVwyMMEW92dzimaRfMictQe0/QbgIzXnPpsWzfwJF6sJC1iGcgUsjoRY0Ucgh6VdgQ9mfjTxitjdIs480ZegaqIRWC51JIX2O6ERtkkiqklVKkWfELgG4RNwPvkNDcvJnaRf2LidVzNw53UslUEIOXmIgStV/DpprR5vgGAg+O6rIAVW8aYL59d6svY9VAwVQxJoONnMCi1A16ntKMBxjyd+ifL9iMTN6PNPrCHX2NlCZ+AzaI+y6RObaT0M0i7xSNzJf4f3YRxrvwit14mJBnDpMSn0zw4rl/CEQzInfG0JKmyRxayCVjprs0yPsZ4Bj5+Lq/uMfQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/17/2023 11:44 AM, Matthew Wilcox wrote: > On Fri, Mar 17, 2023 at 09:58:17AM +0800, Yin, Fengwei wrote: >> >> >> On 3/17/2023 1:52 AM, Matthew Wilcox wrote: >>> On Thu, Mar 16, 2023 at 04:38:58PM +0000, Ryan Roberts wrote: >>>> On 16/03/2023 16:23, Yin, Fengwei wrote: >>>>>> I think you are changing behavior here - is this intentional? Previously this >>>>>> would be evaluated per page, now its evaluated once for the whole range. The >>>>>> intention below is that directly faulted pages are mapped young and prefaulted >>>>>> pages are mapped old. But now a whole range will be mapped the same. >>>>> >>>>> Yes. You are right here. >>>>> >>>>> Look at the prefault and cpu_has_hw_af for ARM64, it looks like we >>>>> can avoid to handle vmf->address == addr specially. It's OK to >>>>> drop prefault and change the logic here a little bit to: >>>>> if (arch_wants_old_prefaulted_pte()) >>>>> entry = pte_mkold(entry); >>>>> else >>>>> entry = pte_sw_mkyong(entry); >>>>> >>>>> It's not necessary to use pte_sw_mkyong for vmf->address == addr >>>>> because HW will set the ACCESS bit in page table entry. >>>>> >>>>> Add Will Deacon in case I missed something here. Thanks. >>>> >>>> I'll defer to Will's response, but not all arm HW supports HW access flag >>>> management. In that case it's done by SW, so I would imagine that by setting >>>> this to old initially, we will get a second fault to set the access bit, which >>>> will slow things down. I wonder if you will need to split this into (up to) 3 >>>> calls to set_ptes()? >>> >>> I don't think we should do that. The limited information I have from >>> various microarchitectures is that the PTEs must differ only in their >>> PFN bits in order to use larger TLB entries. That includes the Accessed >>> bit (or equivalent). So we should mkyoung all the PTEs in the same >>> folio, at least initially. >>> >>> That said, we should still do this conditionally. We'll prefault some >>> other folios too. So I think this should be: >>> >>> bool prefault = (addr > vmf->address) || ((addr + nr) < vmf->address); >>> >> According to commit 46bdb4277f98e70d0c91f4289897ade533fe9e80, if hardware access >> flag is supported on ARM64, there is benefit if prefault PTEs is set as "old". >> If we change prefault like above, the PTEs is set as "yong" which loose benefit >> on ARM64 with hardware access flag. >> >> ITOH, if from "old" to "yong" is cheap, why not leave all PTEs of folio as "old" >> and let hardware to update it to "yong"? > > Because we're tracking the entire folio as a single entity. So we're > better off avoiding the extra pagefaults to update the accessed bit, > which won't actually give us any information (vmscan needs to know "were > any of the accessed bits set", not "how many of them were set"). There is no extra pagefaults to update the accessed bit. There are three cases here: 1. hardware support access flag and cheap from "old" to "yong" without extra fault 2. hardware support access flag and expensive from "old" to "yong" without extra fault 3. no hardware support access flag (extra pagefaults from "old" to "yong". Expensive) For #2 and #3, it's expensive from "old" to "yong", so we always set PTEs "yong" in page fault. For #1, It's cheap from "old" to "yong", so it's OK to set PTEs "old" in page fault. And hardware will set it to "yong" when access memory. Actually, ARM64 with hardware access bit requires to set PTEs "old". > > Anyway, hopefully Ryan can test this and let us know if it fixes the > regression he sees. I highly suspect the regression Ryan saw is not related with this but another my stupid work. I will send out the testing patch soon. Thanks. Regards Yin, Fengwei