From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AEBDC636CC for ; Wed, 8 Feb 2023 14:26:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF3E56B0071; Wed, 8 Feb 2023 09:26:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EA4636B0072; Wed, 8 Feb 2023 09:26:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D44A56B0073; Wed, 8 Feb 2023 09:26:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C4C156B0071 for ; Wed, 8 Feb 2023 09:26:33 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 81851120569 for ; Wed, 8 Feb 2023 14:26:33 +0000 (UTC) X-FDA: 80444350266.08.EF52BD1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 49F6914000E for ; Wed, 8 Feb 2023 14:26:31 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=falS8cGd; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675866391; a=rsa-sha256; cv=none; b=CB7ZHGpuvi3P35Cx4+1vm4tQ8QWvW+d+T2TVyz5xoLGq+QCzQZz/oiP/PFJeaRh9Cia1VC v7nl9X8e1dBTOaNHxW0gvB9vXTZzlX3GLkebF9ZoC/cLQ4CvLRPfglNnt9ayMEhUjDQEpF wyOfGfxIUhy/xu34tIS0U9ndcGyp6BA= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=falS8cGd; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675866391; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jcheR8no+h9/KW9D8B2rlH9xkYEtNZ4C0LmJNrzuL3s=; b=Mf4gQ13xnr+ufPpVcQxpgm3TpUXQOUrUXNYjv4Mx5kcoinNzXlJBr2zCIjxGSdyY61V6kb /eITCJRh/0KDkYROFh+Ap7w1RZpfKAq4xDyu1yJkmqcIhBFuc0oBChAa5PJc4H3f20R8PL vctm/tw1mJOjh73LCmzkdiwd5A1bRBE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675866390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jcheR8no+h9/KW9D8B2rlH9xkYEtNZ4C0LmJNrzuL3s=; b=falS8cGdnr7DeiYcyQTrxsIF1xfeR82tqrYiKeg2hTufrRehTSuMBRlh6L02kUxt7qNVWr NhvtS8ZTA5YEJ43cqDoCyEcYEoowVry97zJhHkLftyShTVLbMAGqpQoGSScFL4buhJsKMw pl8CyyyJdFiy6CXD6PojNWRsQ3AFF5A= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-10-iSMuY8FfMHed0qey09UA_A-1; Wed, 08 Feb 2023 09:26:29 -0500 X-MC-Unique: iSMuY8FfMHed0qey09UA_A-1 Received: by mail-wr1-f69.google.com with SMTP id w10-20020a5d544a000000b002c3de7a10b0so2011926wrv.5 for ; Wed, 08 Feb 2023 06:26:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jcheR8no+h9/KW9D8B2rlH9xkYEtNZ4C0LmJNrzuL3s=; b=BAJad5nTlJQw5vPaj+ZNsp9dhs4WMUaiOex7Bahh4M3egaJQ+0hQtv8IWbskXkLHib HqJWxDKGBbkeYC4m+pgYMstWD86H1rZiLlFqr6wxwWO5vvsNDUNuIWcqiP/+YMABVsk7 Jh5vDpOQEUNYDPOX7P7Ge/adAAvltENInxk3K0Wcb37rTVbaIUaC+KeJQcNN3G8gOgtX RwCe/ESg3dmwP1RS0U2BiSkxr+TZN7t0xVD31wazjtkrBm4wE/LXCqTxOOszu6nJBOOc /9yCvp/W5WPMXBlTCjAa3Gx1A4S55tmyduQXWt/SITb7tPL8F2Hce/j9/c+WahpjkKq8 vNyg== X-Gm-Message-State: AO0yUKUXeqqIU/T56BPt8kmpVepgAyNir7o1GYr1iTPF6QcP0/19uQmH SEjo/RLHDwBFfbfq+vbEulndDAdYVGdbK16ZNzHKaL9kRhEC6YiZwA/TrPkGb9JAjXeSQn8ql1s nb/cIiFKXDwI= X-Received: by 2002:adf:eb41:0:b0:2c3:ff6c:82e with SMTP id u1-20020adfeb41000000b002c3ff6c082emr2588455wrn.22.1675866388114; Wed, 08 Feb 2023 06:26:28 -0800 (PST) X-Google-Smtp-Source: AK7set8AV3P69Fo+9tCyuc39h2Jm4l9tzbO/bJTNceDZqrEqG2kpOZVITFuuz8rKn67JLW4Ijg+42g== X-Received: by 2002:adf:eb41:0:b0:2c3:ff6c:82e with SMTP id u1-20020adfeb41000000b002c3ff6c082emr2588443wrn.22.1675866387829; Wed, 08 Feb 2023 06:26:27 -0800 (PST) Received: from ?IPV6:2003:cb:c704:b300:758c:6214:cd51:8ab0? (p200300cbc704b300758c6214cd518ab0.dip0.t-ipconnect.de. [2003:cb:c704:b300:758c:6214:cd51:8ab0]) by smtp.gmail.com with ESMTPSA id a18-20020a5d4572000000b002c3e7474b0fsm8146904wrc.13.2023.02.08.06.26.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Feb 2023 06:26:27 -0800 (PST) Message-ID: <12c1070d-3126-f240-3390-03eed404be7c@redhat.com> Date: Wed, 8 Feb 2023 15:26:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 03/13] mm/gup: don't call __gup_longterm_locked() if FOLL_LONGTERM cannot be set To: Jason Gunthorpe Cc: Alistair Popple , David Howells , Christoph Hellwig , John Hubbard , linux-mm@kvack.org, "Mike Rapoport (IBM)" References: <3-v2-987e91b59705+36b-gup_tidy_jgg@nvidia.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <3-v2-987e91b59705+36b-gup_tidy_jgg@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 49F6914000E X-Rspamd-Server: rspam01 X-Stat-Signature: tceocoos6t34xyxit14es9hk3z7t5jeh X-HE-Tag: 1675866391-495267 X-HE-Meta: U2FsdGVkX19s8vq5uj78nskDBSBTPKfuoN8mD3mtLwzMKW05iTEXpm7CCyMuJ6KlE+IKe807smPuRdAAgs8Pypjjw94nZQSXpwFHJVenhYEOxf93v89xhN1wUtKYC+hA7XEhSFx0u39SM0T2G0NG1lSkwa7kt9ZrBGH+ex3nsDCjfgjc+T1HbnYKS3mIg7mVzMFxhEZC+Pn5NzG4XSBUUzE6pp3rUOSw/K5KIl29OuB2fNT/tPmYHelEFzCzQUwX/HEaTB8dFsp6tjrOeLtWcY8A1s5W4TMNPng8Vgy03k3B6OZh3VFZg/HcJSduLOV/JkG6IUDWt9wpDRp3BHJH3v/vU35IoulXE6L2qga9hTK0Gpq3sos8MUi3hIo06mn0JNNYrt8BEHnzdgULY9FMjPKfA4BbILMi+inhmaR2iUWsjSr/NrFgbHz+F/fv7tqEClOYQFJYXhk674E4CyVeT80WC+yxz/LQ/WFSVcZsuUWJEqLmaTi9k2bbGaaRqsIzS6ylpT/J8vuq6UGbPS2MAEFM9YWRmH9h2kGwfOXwc99TScQghr8MgTUsbWZREw7qce3oxFTHPaQFred8siE3QlHU/U1ymSXggryFy7PFG6YuLdEYmrwZhmc/LTRchN4rFk6ZkW5gndobRCg28nAv/z8fHnjO04QKCy7WlUah1mWBXFONpIeHhKvJZvGZ29PvM4B5H3S6/Dxzth4A2UpycxZFvWv4806BXYxH7UFxf8mjaVrET1MqaeYHPDQHkpeZKYjf081srqHih0iaiysE4JMuOg/XI4phg//Hxw8COgfVB56tYt9gWww/kTyMwQSLjJ2o3vxGVVYzz0uE14gCLRrK2yBhRyfpJEPVfx76ONvmONxy2HF92ac3NoVTmQ/zzwAIW1udhWlW+E5uRtqvmD+6PlIIzc1BZ8W1Qo03sLFYLjQuotE124nIcxhGGu08KbC+0i0Lf6V/+QGC9xA lLOvLNDU P9rUSPDoHHj41NsKW8Q0fA4kPg4Z0uQ1BgYRG4C2ba7SSjODPehuZ06Js8yPnnZnOaGNELgsZ7iaItmsO9Fkn9aJaxc9jpPTMskwuG+arD0SYDWBlAVDQ7KyIS1QH3fHtYI1uYTF7zgJBPYRGKuIPxjnH7SgMCtp3z7B4PODrBeHn/8jT8HyfHS/xF3Ajm34anmNXrIWFOYo9/DqtESwdasHnbZxyONwgInjniwnre2CW/SE/SHMiV8s7xVReVvKgMrE8FjarDR0ltU/2j1xDlPc7QPG/hyPeQVfKyx/tX3VZvDcKL2OKPOqQB7JFUree37izSQi7HGu+L4bT66JpSkxtJg0SU528xeYPQnNb8O9Ae7tVCkN+CPIFTfAZV3uMlNkyuRbXoRaqBvoJSxLfmlg26lC4MQr0mYcgKQtMJqzc+wbZP1aIo24NvrjEuBwoadUN77HU+MCruwfjafA5OoWzxwYW7r0Pe1ESGyLs6ov56THXqAFJMAtGne2I783LYjtQtsiURR7cm6KBx5yxaNkc93wQgDvVrfrBpr7bsgf5iyQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24.01.23 21:34, Jason Gunthorpe wrote: > get_user_pages_remote(), get_user_pages_unlocked() and get_user_pages() > are never called with FOLL_LONGTERM, so directly call > __get_user_pages_locked() > > The next patch will add an assertion for this. > > Suggested-by: John Hubbard > Reviewed-by: John Hubbard > Acked-by: Mike Rapoport (IBM) > Signed-off-by: Jason Gunthorpe > --- > mm/gup.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 7007b3afc4fda8..a6559d7243db92 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -2200,8 +2200,8 @@ long get_user_pages_remote(struct mm_struct *mm, > if (!is_valid_gup_flags(gup_flags)) > return -EINVAL; > > - return __gup_longterm_locked(mm, start, nr_pages, pages, vmas, locked, > - gup_flags | FOLL_TOUCH | FOLL_REMOTE); > + return __get_user_pages_locked(mm, start, nr_pages, pages, vmas, locked, > + gup_flags | FOLL_TOUCH | FOLL_REMOTE); > } > EXPORT_SYMBOL(get_user_pages_remote); > > @@ -2238,8 +2238,8 @@ long get_user_pages(unsigned long start, unsigned long nr_pages, > if (!is_valid_gup_flags(gup_flags)) > return -EINVAL; > > - return __gup_longterm_locked(current->mm, start, nr_pages, > - pages, vmas, NULL, gup_flags | FOLL_TOUCH); > + return __get_user_pages_locked(current->mm, start, nr_pages, pages, > + vmas, NULL, gup_flags | FOLL_TOUCH); > } > EXPORT_SYMBOL(get_user_pages); > > @@ -2263,8 +2263,8 @@ long get_user_pages_unlocked(unsigned long start, unsigned long nr_pages, > { > int locked = 0; > > - return __gup_longterm_locked(current->mm, start, nr_pages, pages, NULL, > - &locked, gup_flags | FOLL_TOUCH); > + return __get_user_pages_locked(current->mm, start, nr_pages, pages, > + NULL, &locked, gup_flags | FOLL_TOUCH); > } > EXPORT_SYMBOL(get_user_pages_unlocked); > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb