From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 927E0C5475B for ; Thu, 14 Mar 2024 05:00:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9BC580080; Thu, 14 Mar 2024 01:00:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C243080073; Thu, 14 Mar 2024 01:00:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9EF580080; Thu, 14 Mar 2024 01:00:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 91A4E80073 for ; Thu, 14 Mar 2024 01:00:52 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 50361811B9 for ; Thu, 14 Mar 2024 05:00:52 +0000 (UTC) X-FDA: 81894444744.24.79D9735 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf10.hostedemail.com (Postfix) with ESMTP id 415FBC0014 for ; Thu, 14 Mar 2024 05:00:50 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf10.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710392450; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zu9XObwNKHe/hfK0wyajSIgi1jgQQqqs45nPNdguxtY=; b=Cq4YouVXXjaDenzyBgp7KybyGnYrrbtK3DWIIKedhuLnViDy4TzjazxfJQf32iJ0XY72Mo ERAqRs81m7jitnmiVYzGUhOKgX0XzbL5tAX7CUbPWkhWe4QcwG0ggFN0v0jy4wX6zRt/d3 n2VNUPADnCo2qTLBl3meb1T3yK1PTJ0= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf10.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710392450; a=rsa-sha256; cv=none; b=CGCuH5FG5eTfIZrZ4fOR+H7uSIcFVsUO34ePE+9i4M8yLests84mUpELHdTMUYHcQAP9na 2ScGEBAhe3IvW0AYj99Ajs+IfKMW1GUhDpo84BDae++y7hOHR21/sataYyvr/5f+Wx615O nOViaOOdmUQvoOhb/vF8ZES2qoLX2Gs= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6FE671007; Wed, 13 Mar 2024 22:01:25 -0700 (PDT) Received: from [10.162.40.27] (e116581.arm.com [10.162.40.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E78E03F73F; Wed, 13 Mar 2024 22:00:46 -0700 (PDT) Message-ID: <12b0aa90-3b4f-4fb0-b4df-c677f496cb09@arm.com> Date: Thu, 14 Mar 2024 10:30:44 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 12/12] selftests/mm: virtual_address_range: conform to TAP format output Content-Language: en-US To: Muhammad Usama Anjum , Andrew Morton , Shuah Khan Cc: kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Anshuman.Khandual@arm.com References: <20240202113119.2047740-1-usama.anjum@collabora.com> <20240202113119.2047740-13-usama.anjum@collabora.com> From: Dev Jain In-Reply-To: <20240202113119.2047740-13-usama.anjum@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: ha387ki34e7b1iourcu6x16uhjt5kq44 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 415FBC0014 X-HE-Tag: 1710392450-676233 X-HE-Meta: U2FsdGVkX189WiiHepG5tWK/iAkI4FTdRmh84O4crhe21aXRvjaZguqFGPJHnZrlxFqpwfk083GqC2mg0Wu537SsMRyh8cCW9WWgGYIKAY1CBUFQg0ioDJ0iVVe7bWOJ8F+NA0w1/6f0THmyhpnZtkKO3UzytCAzjYyToqQ2WOtpS0FXJ0AEPlL9STSX0Yzxg7FFYX8n3GffQWdPIK4srOukMbXLLtEYozVlEPhf9bx6f8+2Tf7sUvlA2sgKcdFkgz5IsyNbU2q3OA2NZAwrH/wumWwEdSLkcgDDnk2quodCiW7waBVZDfM3hPEc1PtlfSURakCkC9k3+BjRewip5GP3ppprWl3a+a0SrV6GKEYbReIJ1m3uQESdD1rNPI2bTCd9gCEIiATC6uO8eU2KAgcU8zBmLfVGIEGMik9uYFE9fghBAb9zCK2Id7MmpI47KaRfFSW5EU0VICVcQnI4u9rXTg+1SkrWKkyIOcjH3ZG0E7Xqrcqkn4GNZ3LCXvURyeHqbX1xqikSAX5DPTakbcxeivfmKsqq5C0KM+QuK236DV29uzgZh7UsQX4GDzT++f0AddSl4RKDHAxl1mK9rWEe79U3F9DncM5+vVmp9et+sAfxLWHrsTh7hs7nHLkEn7Fi5dHFnhMkUg1rR96zQIefMu9N3HUSTTx9o9V7rWKdjqqSpazO9GHOGm+S4nKiwH/FiX91rxg9QSOjJx1wB8kNgOxGGpVj5v0t0Xmwwqdtmn195CTd4EJXMprWiikW9viKZ0Xx4jTAWw1I/Tsl0SHgPwsL1b3dBsROpPXpZwW68GkSr2AKr7VsAZF+gNNGppqa1boCn2Lz6BUbM3rx2ot64WGmJy3HfA+Uox4H782PPJgzBtrgweTP7PtV5uofMVbRJyPXn64= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/2/24 17:01, Muhammad Usama Anjum wrote: > Conform the layout, informational and status messages to TAP. No > functional change is intended other than the layout of output messages. > > Signed-off-by: Muhammad Usama Anjum > --- > .../selftests/mm/virtual_address_range.c | 44 +++++++++---------- > 1 file changed, 22 insertions(+), 22 deletions(-) > > diff --git a/tools/testing/selftests/mm/virtual_address_range.c b/tools/testing/selftests/mm/virtual_address_range.c > index bae0ceaf95b13..7bcf8d48256a6 100644 > --- a/tools/testing/selftests/mm/virtual_address_range.c > +++ b/tools/testing/selftests/mm/virtual_address_range.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include "../kselftest.h" > > /* > * Maximum address range mapped with a single mmap() > @@ -68,23 +69,15 @@ static char *hind_addr(void) > return (char *) (1UL << bits); > } > > -static int validate_addr(char *ptr, int high_addr) > +static void validate_addr(char *ptr, int high_addr) > { > unsigned long addr = (unsigned long) ptr; > > - if (high_addr) { > - if (addr < HIGH_ADDR_MARK) { > - printf("Bad address %lx\n", addr); > - return 1; > - } > - return 0; > - } > + if (high_addr && addr < HIGH_ADDR_MARK) > + ksft_exit_fail_msg("Bad address %lx\n", addr); > > - if (addr > HIGH_ADDR_MARK) { > - printf("Bad address %lx\n", addr); > - return 1; > - } > - return 0; > + if (addr > HIGH_ADDR_MARK) > + ksft_exit_fail_msg("Bad address %lx\n", addr); > } > > static int validate_lower_address_hint(void) > @@ -107,23 +100,29 @@ int main(int argc, char *argv[]) > char *hint; > unsigned long i, lchunks, hchunks; > > + ksft_print_header(); > + ksft_set_plan(1); > + > for (i = 0; i < NR_CHUNKS_LOW; i++) { > ptr[i] = mmap(NULL, MAP_CHUNK_SIZE, PROT_READ | PROT_WRITE, > MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); > > if (ptr[i] == MAP_FAILED) { > - if (validate_lower_address_hint()) > - return 1; > + if (validate_lower_address_hint()) { > + ksft_test_result_skip("Memory constraint not fulfilled\n"); > + ksft_finished(); > + } Hi, When validate_lower_address_hint() returns 1, it implies that despite filling the lower range, mmap succeeded. IMHO, ksft_exit_fail_msg() should be used instead, with a more descriptive message indicating that the memory was unexpectedly allocated. Regards Dev > break; > } > > - if (validate_addr(ptr[i], 0)) > - return 1; > + validate_addr(ptr[i], 0); > } > lchunks = i; > hptr = (char **) calloc(NR_CHUNKS_HIGH, sizeof(char *)); > - if (hptr == NULL) > - return 1; > + if (hptr == NULL) { > + ksft_test_result_skip("Memory constraint not fulfilled\n"); > + ksft_finished(); > + } > > for (i = 0; i < NR_CHUNKS_HIGH; i++) { > hint = hind_addr(); > @@ -133,8 +132,7 @@ int main(int argc, char *argv[]) > if (hptr[i] == MAP_FAILED) > break; > > - if (validate_addr(hptr[i], 1)) > - return 1; > + validate_addr(hptr[i], 1); > } > hchunks = i; > > @@ -145,5 +143,7 @@ int main(int argc, char *argv[]) > munmap(hptr[i], MAP_CHUNK_SIZE); > > free(hptr); > - return 0; > + > + ksft_test_result_pass("Test\n"); > + ksft_finished(); > }