From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1172C02180 for ; Tue, 14 Jan 2025 01:36:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DA2F6B0085; Mon, 13 Jan 2025 20:36:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 389AF6B008A; Mon, 13 Jan 2025 20:36:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 277D86B008C; Mon, 13 Jan 2025 20:36:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 092386B0085 for ; Mon, 13 Jan 2025 20:36:24 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B25461C6D1C for ; Tue, 14 Jan 2025 01:36:23 +0000 (UTC) X-FDA: 83004342246.08.D7BEFB3 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf07.hostedemail.com (Postfix) with ESMTP id 2F6C340002 for ; Tue, 14 Jan 2025 01:36:22 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736818582; a=rsa-sha256; cv=none; b=Z6x8ZTCc4ew3uQ0Gam+OfWobBAULwHDcRqYIZSU8yIao4s4gBk1ErNnLzBrkyLhAZ7Ng6o DgjYuSoOXDYzPX06LHwmC2TuBcjkDGe5YwOd6u10WcE2SC13dWkurK5n3vs2u4f9MXpe2W ExTgC80KAe0LzD/HwliVMagt5A3VCZ0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736818582; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RQGMVtyvWZ3vVh/wIEmY5Sxm378bLlakCbrQz8eqOzI=; b=Goir2cU6ZQt1w2hdk7FXdVlWmC1gtCnTsPvsNvILJFqpcVzyVp852Q0Qf/WOpovOhXaBwj ncR1aJYz8KHh8mP6sXy/IYuQjsA8R26D0gThj949ttAIJ4xNsX9YyLip7nZHrEucv4O2Ax Q2QhfP44xARU1cNG9Egw14iQGAgHpps= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tXVnn-000000003rI-3gpg; Mon, 13 Jan 2025 20:33:07 -0500 Message-ID: <12ab86daa5c9fde4be692410fd477e97970a3688.camel@surriel.com> Subject: Re: [PATCH v4 05/12] x86/mm: add INVLPGB support code From: Rik van Riel To: Jann Horn Cc: x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org Date: Mon, 13 Jan 2025 20:33:07 -0500 In-Reply-To: References: <20250112155453.1104139-1-riel@surriel.com> <20250112155453.1104139-6-riel@surriel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.1 (3.54.1-1.fc41) MIME-Version: 1.0 X-Rspamd-Queue-Id: 2F6C340002 X-Stat-Signature: 3zguo6k3e3cp63ur3qinquu8d69pus9p X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1736818582-327945 X-HE-Meta: U2FsdGVkX1/Ujv3p/0qVtDRzjfc+bCHqTEIEBPFvr8s1Ovly1wSwpzJ0uP6G9jXFxSD6L/7NGKbZymIONzbODG8pI1pYly8/VoFOIvksglLQ1Bt/947VsqmoyL0TrHrBnRdL3pdPGbc/IAAyvggkMTf1IIIaqWmK1q21ZcNGVr34QEhGeSPbVpffHQYZYmiym5nHUE5SrO7PX4Jpy3lgmXtDRjT4T4DNQ9V3PacM6nDXZ4UV9Y2fweZAGWWRd1MQ/RtrmzmvvfKRihJcNShxlypPxLkRAwvwMDc4ZCo3XT/+npif5Pv9SZOhEhAWUhb4MAVBe1neSuz1RS6nRYiC1WqOD3tjGkx1ytMGPr06sNDCkW5lG0KPbOXcTplNJXb56euARwfu4+Y9DxPal8+OtV3fh+sbaS7mKaHb70Hct4T+uSAqLwoJZRz6PtBmpxbZMnMVXtyVgOVf/1jS8W/TVrgop8tFAzy5C6kLqEnRvEnk8yu+f5wt6RPxNAg5BfTUqIKRQx1/jHCrZ04VobouMZHwoxfzuf1MtjqjjtkZ5MG9TBAYxBBjKXxkFfRmMQhIuiXei1HMBr8uPWNz/Hkc4QsT1LaJDszbRPs+v1rVeOJaZU+OdbrrZssvn0FX2i6o9m+KQ9YOVrH9h+JJnDmqoQtRn2gLRF6i9IC1wVNVBUB3LI0nyGfZrgKqE70lvYj09inZUss4iPq7VA8zvOvZ10/g5NzBJwFhGObVHMffXENolP1yFZdF3wAnWTrvCECvNGJNgFVWq70UMxqMjil4Kzq4Qv+EtlZn3lmi+Mw1eou2xk1W9tdOBfxFKlmio3CSVgGBGf/BtzC8agohFSAn8Ua4JpeED1WrIHdZOZbLjGhL0BjHHnQdg/lLZdfo2Z0ttELRKkiArbwMcIuEvOSZSySBjIdERQ5Ak8pRM8gCFHrGTEAPlBtCTo4kuyKO3QhZBGv4scwxyA7qlYZt2LS P4aFz24e ihcOtP1jvhXH31TfAKJ7kpmP0tU+NwIhgRcqL+OhHo4/R30bxucTvWemHHIAf9wRC5A7on93CtoqFRmVf22l2vsiEGHUvApumwaeJpVJzcpNN/sc0106UJkX2ZPvJp+sZKM0i+3nWT+UQYjluiEMn6wJvuiAc8+TN3Z7XMoHZkzcc+h9RkdrQzTXKlblcr6BGA/L6JjLobPulCCcM8mWbSUS1EVGIo6dF4ruF/nw27h/+euG71zIRoz3HCESqfECw/3BdYpJQHfcdqbf34JVXDwFcXmJqNSH8tORwzruXBu8nWVByo5MXNCtu69P5102hI0o8GFiTYTJkZo7y+huwOhtGfVc+QOhHnAVGkRnT45j6vFdSmqOMID93d26y+H7GWihDQqZisKs4w1g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 2025-01-13 at 18:24 +0100, Jann Horn wrote: > On Sun, Jan 12, 2025 at 4:55=E2=80=AFPM Rik van Riel > wrote: > > +/* Wait for INVLPGB originated by this CPU to complete. */ > > +static inline void tlbsync(void) > > +{ > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 asm volatile("tlbsync"); > > +} >=20 > If possible, it might be a good idea to add a cant_migrate() > assertion > in here, though I'm not sure if that works in terms of include > hierarchy. >=20 Nice idea. It just builds without any compiler issues, so I've included that for the next version. --=20 All Rights Reversed.