From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with ESMTP id 073C28D0069 for ; Fri, 21 Jan 2011 01:32:53 -0500 (EST) From: Naoya Horiguchi Subject: [PATCH 3/7] remove putback_lru_pages() in hugepage migration context Date: Fri, 21 Jan 2011 15:28:56 +0900 Message-Id: <1295591340-1862-4-git-send-email-n-horiguchi@ah.jp.nec.com> In-Reply-To: <1295591340-1862-1-git-send-email-n-horiguchi@ah.jp.nec.com> References: <1295591340-1862-1-git-send-email-n-horiguchi@ah.jp.nec.com> Sender: owner-linux-mm@kvack.org To: Andi Kleen Cc: Andrew Morton , Wu Fengguang , Mel Gorman , Christoph Lameter , Huang Ying , Fernando Luis Vazquez Cao , tony.luck@intel.com, LKML , linux-mm , Minchan Kim List-ID: This putback_lru_pages() is inserted at cf608ac19c to allow memory compaction to count the number of migration failed pages. But we should not do it for a hugepage because page->lru of a hugepage is used differently from that of a normal page: in-use hugepage : page->lru is unlinked, free hugepage : page->lru is linked to the free hugepage list, so putting back hugepages to LRU lists collapses this rule. We just drop this change (without any impact on memory compaction.) Signed-off-by: Naoya Horiguchi Cc: Minchan Kim --- mm/memory-failure.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git v2.6.38-rc1/mm/memory-failure.c v2.6.38-rc1/mm/memory-failure.c index 548fbd7..b4910e8 100644 --- v2.6.38-rc1/mm/memory-failure.c +++ v2.6.38-rc1/mm/memory-failure.c @@ -1295,7 +1295,6 @@ static int soft_offline_huge_page(struct page *page, int flags) ret = migrate_huge_pages(&pagelist, new_page, MPOL_MF_MOVE_ALL, 0, true); if (ret) { - putback_lru_pages(&pagelist); pr_debug("soft offline: %#lx: migration failed %d, type %lx\n", pfn, ret, page->flags); if (ret > 0) -- 1.7.3.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org