linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: Andi Kleen <tatsu@ab.jp.nec.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Wu Fengguang <fengguang.wu@intel.com>, Mel Gorman <mel@csn.ul.ie>,
	Christoph Lameter <cl@linux-foundation.org>,
	Huang Ying <ying.huang@intel.com>,
	Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>,
	tony.luck@intel.com, LKML <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>,
	Minchan Kim <minchan.kim@gmail.com>
Subject: [PATCH 3/7] remove putback_lru_pages() in hugepage migration context
Date: Fri, 21 Jan 2011 15:28:56 +0900	[thread overview]
Message-ID: <1295591340-1862-4-git-send-email-n-horiguchi@ah.jp.nec.com> (raw)
In-Reply-To: <1295591340-1862-1-git-send-email-n-horiguchi@ah.jp.nec.com>

This putback_lru_pages() is inserted at cf608ac19c to allow
memory compaction to count the number of migration failed pages.

But we should not do it for a hugepage because page->lru of a hugepage
is used differently from that of a normal page:

   in-use hugepage : page->lru is unlinked,
   free hugepage   : page->lru is linked to the free hugepage list,

so putting back hugepages to LRU lists collapses this rule.
We just drop this change (without any impact on memory compaction.)

Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Minchan Kim <minchan.kim@gmail.com>
---
 mm/memory-failure.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git v2.6.38-rc1/mm/memory-failure.c v2.6.38-rc1/mm/memory-failure.c
index 548fbd7..b4910e8 100644
--- v2.6.38-rc1/mm/memory-failure.c
+++ v2.6.38-rc1/mm/memory-failure.c
@@ -1295,7 +1295,6 @@ static int soft_offline_huge_page(struct page *page, int flags)
 	ret = migrate_huge_pages(&pagelist, new_page, MPOL_MF_MOVE_ALL, 0,
 				true);
 	if (ret) {
-		putback_lru_pages(&pagelist);
 		pr_debug("soft offline: %#lx: migration failed %d, type %lx\n",
 			 pfn, ret, page->flags);
 		if (ret > 0)
-- 
1.7.3.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2011-01-21  6:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-21  6:28 [PATCH 0/7] HWPOISON for hugepage backed KVM guest Naoya Horiguchi
2011-01-21  6:28 ` [PATCH 1/7] hugetlb: check swap entry in follow_hugetlb_page() Naoya Horiguchi
2011-01-21  6:28 ` [PATCH 2/7] check hugepage swap entry in get_user_pages_fast() Naoya Horiguchi
2011-01-21  6:28 ` Naoya Horiguchi [this message]
2011-01-21  6:40   ` [PATCH 3/7] remove putback_lru_pages() in hugepage migration context Minchan Kim
2011-01-21 10:00     ` Naoya Horiguchi
2011-01-21  6:28 ` [PATCH 4/7] hugetlb, migration: add migration_hugepage_entry_wait() Naoya Horiguchi
2011-01-21  6:28 ` [PATCH 5/7] hugetlb: fix race condition between hugepage soft offline and page fault Naoya Horiguchi
2011-01-21  6:28 ` [PATCH 6/7] HWPOISON: pass order to set/clear_page_hwpoison_huge_page() Naoya Horiguchi
2011-01-21  6:29 ` [PATCH 7/7] HWPOISON, hugetlb: fix hard offline for hugepage backed KVM guest Naoya Horiguchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1295591340-1862-4-git-send-email-n-horiguchi@ah.jp.nec.com \
    --to=n-horiguchi@ah.jp.nec.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=fernando@oss.ntt.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=minchan.kim@gmail.com \
    --cc=tatsu@ab.jp.nec.com \
    --cc=tony.luck@intel.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox