From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with ESMTP id B3BDD6B008C for ; Mon, 20 Dec 2010 09:52:46 -0500 (EST) Subject: Re: [Xen-devel] [PATCH 2/3] drivers/xen/balloon.c: Various balloon features and fixes From: Ian Campbell In-Reply-To: <20101220134724.GC6749@router-fw-old.local.net-space.pl> References: <20101220134724.GC6749@router-fw-old.local.net-space.pl> Content-Type: text/plain; charset="UTF-8" Date: Mon, 20 Dec 2010 14:51:44 +0000 Message-ID: <1292856704.4500.249.camel@zakaz.uk.xensource.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Daniel Kiper Cc: "akpm@linux-foundation.org" , "andi.kleen@intel.com" , "haicheng.li@linux.intel.com" , "fengguang.wu@intel.com" , "jeremy@goop.org" , "konrad.wilk@oracle.com" , Dan Magenheimer , "v.tolstov@selfip.ru" , "xen-devel@lists.xensource.com" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" List-ID: On Mon, 2010-12-20 at 13:47 +0000, Daniel Kiper wrote: > Features and fixes: > - HVM mode is supported now, > - migration from mod_timer() to schedule_delayed_work(), > - removal of driver_pages (I do not have seen any > references to it), > - protect before CPU exhaust by event/x process during > errors by adding some delays in scheduling next event, > - some other minor fixes. Each of those bullets should be a separate patch (or several if appropriate). I didn't review most of the rest because it mixed so much stuff together but a couple of minor things jumped out. > -static void scrub_page(struct page *page) > +static inline void scrub_page(struct page *page) Is there some reason we need to override the compiler's decision here? There is some discussion of the (over)use of inline in CodingStyle. > static struct attribute_group balloon_info_group = { > .name = "info", > - .attrs = balloon_info_attrs, > + .attrs = balloon_info_attrs > }; > > static struct sysdev_class balloon_sysdev_class = { > - .name = BALLOON_CLASS_NAME, > + .name = BALLOON_CLASS_NAME > }; I don't think there is anything wrong with the existing style here. Ian. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org