From: Bob Liu <lliubbo@gmail.com>
To: akpm@linux-foundation.org
Cc: fengguang.wu@intel.com, linux-mm@kvack.org, kenchen@google.com,
Bob Liu <lliubbo@gmail.com>
Subject: [PATCH v2] fix __set_page_dirty_no_writeback() return value
Date: Thu, 11 Nov 2010 11:05:54 +0800 [thread overview]
Message-ID: <1289444754-29469-1-git-send-email-lliubbo@gmail.com> (raw)
__set_page_dirty_no_writeback() should return true if it actually transitioned
the page from a clean to dirty state although it seems nobody used its return
value now.
Change from v1:
* preserving cacheline optimisation as Andrew pointed out
Signed-off-by: Bob Liu <lliubbo@gmail.com>
---
mm/page-writeback.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index bf85062..ac7018a 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -1157,8 +1157,10 @@ EXPORT_SYMBOL(write_one_page);
*/
int __set_page_dirty_no_writeback(struct page *page)
{
- if (!PageDirty(page))
+ if (!PageDirty(page)) {
SetPageDirty(page);
+ return 1;
+ }
return 0;
}
--
1.6.3.3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2010-11-11 2:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 3:05 Bob Liu [this message]
2010-11-11 3:02 ` Andrew Morton
2010-11-11 3:08 ` Bob Liu
2010-11-11 3:26 ` Wu Fengguang
2010-11-11 3:36 ` Bob Liu
2010-11-11 3:45 ` Wu Fengguang
2010-11-11 7:17 ` Bob Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289444754-29469-1-git-send-email-lliubbo@gmail.com \
--to=lliubbo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=kenchen@google.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox