From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with ESMTP id 324836B0087 for ; Wed, 10 Nov 2010 03:48:34 -0500 (EST) From: Bob Liu Subject: [PATCH 1/2] fix __set_page_dirty_no_writeback() return value Date: Wed, 10 Nov 2010 17:00:27 +0800 Message-ID: <1289379628-14044-1-git-send-email-lliubbo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Sender: owner-linux-mm@kvack.org To: akpm@linux-foundation.org Cc: fengguang.wu@intel.com, linux-mm@kvack.org, kenchen@google.com, Bob Liu List-ID: __set_page_dirty_no_writeback() should return true if it actually transitioned the page from a clean to dirty state although it seems nobody used its return value now. Signed-off-by: Bob Liu --- mm/page-writeback.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/mm/page-writeback.c b/mm/page-writeback.c index bf85062..e8f5f06 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -1157,9 +1157,7 @@ EXPORT_SYMBOL(write_one_page); */ int __set_page_dirty_no_writeback(struct page *page) { - if (!PageDirty(page)) - SetPageDirty(page); - return 0; + return !TestSetPageDirty(page); } /* -- 1.6.3.3 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org