From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA3CBC54E41 for ; Wed, 28 Feb 2024 08:29:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F0626B02B3; Wed, 28 Feb 2024 03:29:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A09A6B02B5; Wed, 28 Feb 2024 03:29:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4413D6B02B6; Wed, 28 Feb 2024 03:29:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 38D4E6B02B3 for ; Wed, 28 Feb 2024 03:29:09 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DC67C40F00 for ; Wed, 28 Feb 2024 08:29:08 +0000 (UTC) X-FDA: 81840537576.12.445B0A1 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf18.hostedemail.com (Postfix) with ESMTP id 7F6C81C0007 for ; Wed, 28 Feb 2024 08:29:06 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=NTHWxN9u; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Kz7eaScw; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=NTHWxN9u; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Kz7eaScw; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709108947; a=rsa-sha256; cv=none; b=RiOeDxtsbgjFpQE2Y4hkFks0HhsIJ/RBwK1V6AtkcvBu91QTKZR/02X51POuwXqNwY34RJ PAQBvG2sDsxrHalQ4OXmeaEoklteQ/6aqjZf4Y8GOo6koSvUwS1r9zFEOV0yh9J3Z6IxW7 nrlUxJ/jvcf1wWyBD/a7Ozrmxwd8fis= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=NTHWxN9u; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Kz7eaScw; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=NTHWxN9u; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Kz7eaScw; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709108947; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+HoIz2Qi98NBEh6aNkVpIyLsbtr/CQMlELkE74c1McU=; b=MMAvvZ8mG1ePofeRSaOT4VyV1+jaJv64EBgjUDSs60upgVByOrQTnMl1MIiDeHH2Z6oqa9 srRWwJNQu83wmoHzliSnTV4I1IX7nCRMDYZNrpDhLeAt6dqmSPiH67WkljNydNEFu16RRs kSitYO2iFPGpNguXC6zGvviDEOCxS8c= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A012E1FD5F; Wed, 28 Feb 2024 08:29:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1709108944; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+HoIz2Qi98NBEh6aNkVpIyLsbtr/CQMlELkE74c1McU=; b=NTHWxN9ulO5ErLuP4gcTOYnNmaQsCFQdtc5+CSvK1qSM6duhZPY03zDynWgiAr3Ps+/FqA I9d3Yq0J2sd+xQ93Bbt0VKJTHIHPgz9OCriSsPTHC/y6cg9TM45uXq8YWl7oELJG+97edo 3NypH+V4B9bZ7Ul0xa2a80i+Xl0ZdXw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1709108944; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+HoIz2Qi98NBEh6aNkVpIyLsbtr/CQMlELkE74c1McU=; b=Kz7eaScwzxbvWjw0SaPKEc7jGN/VEKGTH5sed6LnSIGKuhRPu/OyQw33mkVFtMRAcWoR62 lF6+/G+iqvDQN5DQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1709108944; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+HoIz2Qi98NBEh6aNkVpIyLsbtr/CQMlELkE74c1McU=; b=NTHWxN9ulO5ErLuP4gcTOYnNmaQsCFQdtc5+CSvK1qSM6duhZPY03zDynWgiAr3Ps+/FqA I9d3Yq0J2sd+xQ93Bbt0VKJTHIHPgz9OCriSsPTHC/y6cg9TM45uXq8YWl7oELJG+97edo 3NypH+V4B9bZ7Ul0xa2a80i+Xl0ZdXw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1709108944; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+HoIz2Qi98NBEh6aNkVpIyLsbtr/CQMlELkE74c1McU=; b=Kz7eaScwzxbvWjw0SaPKEc7jGN/VEKGTH5sed6LnSIGKuhRPu/OyQw33mkVFtMRAcWoR62 lF6+/G+iqvDQN5DQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1430F13A58; Wed, 28 Feb 2024 08:29:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id IqSSBNDu3mWDHQAAD6G6ig (envelope-from ); Wed, 28 Feb 2024 08:29:04 +0000 Message-ID: <1287d17e-9f9e-49a4-8db7-cf3bbbb15d02@suse.cz> Date: Wed, 28 Feb 2024 09:29:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 14/36] lib: add allocation tagging support for memory allocation profiling Content-Language: en-US To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org References: <20240221194052.927623-1-surenb@google.com> <20240221194052.927623-15-surenb@google.com> From: Vlastimil Babka In-Reply-To: <20240221194052.927623-15-surenb@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7F6C81C0007 X-Stat-Signature: dksqanmwytd4onuqdhtcenbijqqzb51z X-Rspam-User: X-HE-Tag: 1709108946-786197 X-HE-Meta: U2FsdGVkX1+RUw3TXGu5mAie7pDRPYz8/NvuaCZgnrtwJ7arGeWfr7HkigQXkgF6c8c9gWVPYNdxUigQdx9uejWWQ52vw6jqU36oJtCArAKuWxktO9OCrTwu/58M5AyVrRTyxNpHfvBNpICri8mwve7S6Re0u0fPuW6hlere/1qCn2OTgQdOYoUP4k35T8xApuXoj1zk+NK0pzDscEQqzozgaVmXKKdWQKHkDP8pWAfmiBiUNkFLpWaEgIgoRVb5o2Y+ZAnGLV72UJpU4QKwVUo1xSi3O6H/O6ukiJI2Al4K3LB9KCOVia/0tNkaH7+AmmGZZFAC6MKGqKdP9GYsGptZRL9wsBbRIix/3lORX/Hw7V2nWDB5znlcnavm0Ab3jSMv5KJkRmI/yej48NPZR2CbQ+6DY1wR+K8fL38RcEyCvvkMvn2VezeXhOEkiY7NRUhdlRLNbMRdqVxa6r35aiudU3rdv4WGcLhi2mCz/E6QsiTODEqxc2/KnkuCIm0gttyXJRv06w9BWqKMZctzHLci/U/5EECBiIA1Kstms6G41hajzW1fi95cfmGfOa26gQK4i45PNZu47QNJcvvNs87Pjx1JJmD07eYQgxYh6ZI8LhOX3kcplyytzyI7N8LvooJgWOmn8dDocCoNjjLCMDjAx/eh4vOfQwS91jidcq/HuxWmcSiMsKIgBNd2gCsO/laCcdG73977Y1qqB0byhXtwm03bnO9RvK26VGza1ZHTk72skdypgi/EcazziQylQZzASOqZUDI3tOmQDhv7JF82bHBJWAcNrWiBYNKlonqsbqzvFlnHBQ5PNFpedxPmLmXx1noUMfzB7J6o5upUs67d27MtR+DfWZME3aUG1bM0EsYScOP2OF57em/apZe8o6KAdbN0XexiQGOH407kAXQ9/M+S++1WqCLF8Z+KG6ohp7kirCvh27uOpZVlRJfGfJjXC+fqec+Z16UGuIm CqolAGjI jcVoI+mkn4on2jqU2gySvyG6AGg6Ml+ALQ3NF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/21/24 20:40, Suren Baghdasaryan wrote: > > +static inline void alloc_tag_sub(union codetag_ref *ref, size_t bytes) > +{ > + __alloc_tag_sub(ref, bytes); > +} > + > +static inline void alloc_tag_sub_noalloc(union codetag_ref *ref, size_t bytes) > +{ > + __alloc_tag_sub(ref, bytes); > +} > + Nit: just notice these are now the same and maybe you could just drop both wrappers and rename __alloc_tag_sub to alloc_tag_sub?