From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id 268886B01F1 for ; Mon, 30 Aug 2010 15:23:09 -0400 (EDT) Subject: Re: why are WB_SYNC_NONE COMMITs being done with FLUSH_SYNC set ? From: Trond Myklebust In-Reply-To: <20100820132309.GB20126@localhost> References: <20100819101525.076831ad@barsoom.rdu.redhat.com> <20100819143710.GA4752@infradead.org> <1282229905.6199.19.camel@heimdal.trondhjem.org> <20100819151618.5f769dc9@tlielax.poochiereds.net> <1282246999.7799.66.camel@heimdal.trondhjem.org> <20100820132309.GB20126@localhost> Content-Type: text/plain; charset="UTF-8" Date: Mon, 30 Aug 2010 15:22:54 -0400 Message-ID: <1283196174.2920.4.camel@heimdal.trondhjem.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Wu Fengguang Cc: Jeff Layton , Christoph Hellwig , linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org List-ID: On Fri, 2010-08-20 at 21:23 +0800, Wu Fengguang wrote: > > > Here's a lightly tested patch that turns the check for the two flags > > > into a check for WB_SYNC_NONE. It seems to do the right thing, but I > > > don't have a clear testcase for it. Does this look reasonable? > > > > Looks fine to me. I'll queue it up for the post-2.6.36 merge window... > > Trond, I just created a patch that removes the wbc->nonblocking > definition and all its references except NFS. So there will be merge > dependencies. What should we do? To push both patches to Andrew's -mm > tree? > > Thanks, > Fengguang Do you want to include it as part of your series? Just remember to add an Acked-by: Trond Myklebust Cheers Trond -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org