From: Matt Mackall <mpm@selenic.com>
To: David Rientjes <rientjes@google.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
Christoph Lameter <cl@linux-foundation.org>,
linux-mm@kvack.org
Subject: Re: [patch] slob: fix gfp flags for order-0 page allocations
Date: Mon, 23 Aug 2010 23:26:34 -0500 [thread overview]
Message-ID: <1282623994.10679.921.camel@calx> (raw)
In-Reply-To: <alpine.DEB.2.00.1008221615350.29062@chino.kir.corp.google.com>
On Sun, 2010-08-22 at 16:16 -0700, David Rientjes wrote:
> kmalloc_node() may allocate higher order slob pages, but the __GFP_COMP
> bit is only passed to the page allocator and not represented in the
> tracepoint event. The bit should be passed to trace_kmalloc_node() as
> well.
>
> Signed-off-by: David Rientjes <rientjes@google.com>
> unsigned int order = get_order(size);
>
> - ret = slob_new_pages(gfp | __GFP_COMP, get_order(size), node);
> + if (likely(order))
> + gfp |= __GFP_COMP;
Why is it likely? I would hope that the majority of page allocations are
in fact order 0.
--
Mathematics is the supreme nostalgia of our time.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-08-24 4:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-22 23:16 David Rientjes
2010-08-23 0:51 ` Christoph Lameter
2010-08-24 4:26 ` Matt Mackall [this message]
2010-08-24 4:36 ` David Rientjes
2010-08-24 15:20 ` Matt Mackall
2010-08-24 15:37 ` Christoph Lameter
2010-08-24 20:24 ` David Rientjes
2010-08-24 17:44 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282623994.10679.921.camel@calx \
--to=mpm@selenic.com \
--cc=cl@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox