From: David Hildenbrand <david@redhat.com>
To: Chris Li <chrisl@kernel.org>
Cc: Daniel Gomez <da.gomez@samsung.com>,
Ryan Roberts <ryan.roberts@arm.com>,
Barry Song <v-songbaohua@oppo.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Luis Chamberlain <mcgrof@kernel.org>,
Pankaj Raghav <p.raghav@samsung.com>,
David Rientjes <rientjes@google.com>
Subject: Re: Swap Min Odrer
Date: Wed, 8 Jan 2025 22:24:16 +0100 [thread overview]
Message-ID: <127a4c29-e34d-401c-a642-cc73d9d1c2f6@redhat.com> (raw)
In-Reply-To: <CACePvbXRzK5pomkAYs6VXd8qvWXWDN8BydxDPkD7H9kWPn11Qg@mail.gmail.com>
On 08.01.25 22:19, Chris Li wrote:
> On Wed, Jan 8, 2025 at 12:36 PM David Hildenbrand <david@redhat.com> wrote:
>>
>>>> Maybe the swapcache could somehow abstract that? We currently have the swap
>>>> slot allocator, that assigns slots to pages.
>>>>
>>>> Assuming we have a 16 KiB BS but a 4 KiB page, we might have various options
>>>> to explore.
>>>>
>>>> For example, we could size swap slots 16 KiB, and assign even 4 KiB pages a
>>>> single slot. This would waste swap space with small folios, that would go
>>>> away with large folios.
>>>
>>> So batching order-0 folios in bigger slots that match the FS BS (e.g. 16
>>> KiB) to perform disk writes, right?
>>
>> Batching might be one idea, but the first idea I raised here would be
>> that the swap slot size will match the BS (e.g., 16 KiB) and contain at
>> most one folio.
>>
>> So a order-0 folio would get a single slot assigned and effectively
>> "waste" 12 KiB of disk space.
>
> I prefer not to "waste" that. It will be wasted on the write
> amplification as well.
If it can be implemented fairly easily, sure! :)
Looking forward to hearing about the proposal!
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2025-01-08 21:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250107094349eucas1p1c973738624046458bbd8ca980cf6fe33@eucas1p1.samsung.com>
2025-01-07 9:43 ` Daniel Gomez
2025-01-07 10:31 ` David Hildenbrand
2025-01-07 12:29 ` Daniel Gomez
2025-01-07 16:41 ` David Hildenbrand
2025-01-08 14:14 ` Daniel Gomez
2025-01-08 20:36 ` David Hildenbrand
2025-01-08 21:19 ` Chris Li
2025-01-08 21:24 ` David Hildenbrand [this message]
2025-01-16 8:38 ` Chris Li
2025-01-20 12:02 ` David Hildenbrand
2025-01-09 3:38 ` David Rientjes
2025-01-08 21:09 ` Chris Li
2025-01-08 21:05 ` Chris Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=127a4c29-e34d-401c-a642-cc73d9d1c2f6@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=chrisl@kernel.org \
--cc=da.gomez@samsung.com \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=p.raghav@samsung.com \
--cc=rientjes@google.com \
--cc=ryan.roberts@arm.com \
--cc=v-songbaohua@oppo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox