From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mel@csn.ul.ie>, Wu Fengguang <fengguang.wu@intel.com>,
Jun'ichi Nomura <j-nomura@ce.jp.nec.com>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 4/7] hugetlb: add hugepage check in mem_cgroup_{register,end}_migration()
Date: Fri, 2 Jul 2010 14:47:23 +0900 [thread overview]
Message-ID: <1278049646-29769-5-git-send-email-n-horiguchi@ah.jp.nec.com> (raw)
In-Reply-To: <1278049646-29769-1-git-send-email-n-horiguchi@ah.jp.nec.com>
Currently memory cgroup doesn't charge hugepage,
so avoid calling these functions in hugepage migration context.
Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
---
mm/memcontrol.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git v2.6.35-rc3-hwpoison/mm/memcontrol.c v2.6.35-rc3-hwpoison/mm/memcontrol.c
index c6ece0a..fed32de 100644
--- v2.6.35-rc3-hwpoison/mm/memcontrol.c
+++ v2.6.35-rc3-hwpoison/mm/memcontrol.c
@@ -2504,6 +2504,8 @@ int mem_cgroup_prepare_migration(struct page *page,
if (mem_cgroup_disabled())
return 0;
+ if (PageHuge(page))
+ return 0;
pc = lookup_page_cgroup(page);
lock_page_cgroup(pc);
@@ -2591,6 +2593,9 @@ void mem_cgroup_end_migration(struct mem_cgroup *mem,
if (!mem)
return;
+ if (PageHuge(oldpage))
+ return;
+
/* blocks rmdir() */
cgroup_exclude_rmdir(&mem->css);
/* at migration success, oldpage->mapping is NULL. */
--
1.7.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-07-02 5:49 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-02 5:47 [PATCH 0/7] hugepage migration Naoya Horiguchi
2010-07-02 5:47 ` [PATCH 1/7] hugetlb: add missing unlock in avoidcopy path in hugetlb_cow() Naoya Horiguchi
2010-07-02 8:31 ` Andi Kleen
2010-07-05 8:44 ` Naoya Horiguchi
2010-07-07 22:17 ` Andi Kleen
2010-07-02 5:47 ` [PATCH 2/7] hugetlb, HWPOISON: move PG_HWPoison bit check Naoya Horiguchi
2010-07-02 5:47 ` [PATCH 3/7] hugetlb: add allocate function for hugepage migration Naoya Horiguchi
2010-07-02 9:08 ` Andi Kleen
2010-07-05 8:46 ` Naoya Horiguchi
2010-07-05 9:28 ` Andi Kleen
2010-07-02 5:47 ` Naoya Horiguchi [this message]
2010-07-02 9:11 ` [PATCH 4/7] hugetlb: add hugepage check in mem_cgroup_{register,end}_migration() Andi Kleen
2010-07-02 5:47 ` [PATCH 5/7] hugetlb: pin oldpage in page migration Naoya Horiguchi
2010-07-05 9:45 ` Andi Kleen
2010-07-06 15:54 ` Christoph Lameter
2010-07-07 6:40 ` Naoya Horiguchi
2010-07-02 5:47 ` [PATCH 6/7] hugetlb: hugepage migration core Naoya Horiguchi
2010-07-05 9:59 ` Andi Kleen
2010-07-06 3:33 ` Naoya Horiguchi
2010-07-06 7:13 ` Andi Kleen
2010-07-07 6:05 ` Naoya Horiguchi
2010-07-07 9:27 ` Andi Kleen
2010-07-08 5:44 ` Naoya Horiguchi
2010-07-08 6:49 ` Andi Kleen
2010-07-06 16:02 ` Christoph Lameter
2010-07-07 6:44 ` Naoya Horiguchi
2010-07-06 16:00 ` Christoph Lameter
2010-07-07 6:45 ` Naoya Horiguchi
2010-07-02 5:47 ` [PATCH 7/7] hugetlb, HWPOISON: soft offlining for hugepage Naoya Horiguchi
2010-07-05 10:28 ` Andi Kleen
2010-07-02 8:30 ` [PATCH 0/7] hugepage migration Andi Kleen
2010-07-05 8:44 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278049646-29769-5-git-send-email-n-horiguchi@ah.jp.nec.com \
--to=n-horiguchi@ah.jp.nec.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=fengguang.wu@intel.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox