From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1926CECAAD4 for ; Mon, 29 Aug 2022 12:19:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D208940008; Mon, 29 Aug 2022 08:19:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6594D940007; Mon, 29 Aug 2022 08:19:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D47B940008; Mon, 29 Aug 2022 08:19:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3CFF0940007 for ; Mon, 29 Aug 2022 08:19:04 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0ACF2A0310 for ; Mon, 29 Aug 2022 12:19:04 +0000 (UTC) X-FDA: 79852534608.10.714740F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 8FB8F1C003A for ; Mon, 29 Aug 2022 12:19:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661775543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qHsCu4PSGMMuSAfnOsJ7Dba+vX8wHbqdb2+wxTgeECc=; b=cm9uOONIBZOA+DpcrMx4jSatIralsZ58MvoBpjW86lgxZnfvU3zu3nJfP3+UDVvQXukDpz J52EspSavQuQ943BdLlVErNvundyYnf+vAmI4b+FVZP99CtXHQ37SZp5euf5VXvgUyZ8eL AJU+fGdy40twv/FNExgIcteAd3F+x6I= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-54-UnnXIZYhOueZLxSehJH2bQ-1; Mon, 29 Aug 2022 08:19:01 -0400 X-MC-Unique: UnnXIZYhOueZLxSehJH2bQ-1 Received: by mail-wm1-f72.google.com with SMTP id h82-20020a1c2155000000b003a64d0510d9so4990474wmh.8 for ; Mon, 29 Aug 2022 05:19:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=qHsCu4PSGMMuSAfnOsJ7Dba+vX8wHbqdb2+wxTgeECc=; b=iKb55+dsshjEz3ywTy0LSFKwb23ja8KddGf3ATbNxb3DivZZHxk5B3E0tP63nfrtUs muPVNLaPiUQ8zey2nwtGZvPubNakPTcjX06oCiax64vJ7xZxhiegreqRSPWCmXlV1RHZ 310lSFsDbbQMenC5+sVYtk3fXsKZ82cknzfxvSyxGvAT2e4wo8I7ysGcAwDwhq395E8H AwTQ9HNCufguR09FO0x952WzAGfudotWjHzpTc3hsXcfBTVta/EDwATAa4w+MsLR02RF WrgXMFCC7X/o1Yq+dUlH2jN/j4zEJ59oBn+cxJbmzlnUNtagLyWNfO/AdjyjZ2UnbxYL TB5w== X-Gm-Message-State: ACgBeo0Uzw55B5gjKfOpqxb30vSPWygs1XUKm5ZrG63HgDZGDScUfzXu smSW4CetKmh1Sfvrwebmm9IXKnl48uB9iZjsFKpIjSQJOF4Rq/sSY5TchCh1F0WDO3A2KU4Gwwi W4lobl2nttr0= X-Received: by 2002:a05:600c:4148:b0:3a5:4f94:577b with SMTP id h8-20020a05600c414800b003a54f94577bmr6847177wmm.167.1661775540283; Mon, 29 Aug 2022 05:19:00 -0700 (PDT) X-Google-Smtp-Source: AA6agR566u8yQL/dsHj6E0xJFg9T/xKNBx103f42nGS1y+P4fOgxuaxBGSCYrKHG6wpysCcd27sWAw== X-Received: by 2002:a05:600c:4148:b0:3a5:4f94:577b with SMTP id h8-20020a05600c414800b003a54f94577bmr6847159wmm.167.1661775539960; Mon, 29 Aug 2022 05:18:59 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:3900:658b:bed0:4260:4c25? (p200300cbc7073900658bbed042604c25.dip0.t-ipconnect.de. [2003:cb:c707:3900:658b:bed0:4260:4c25]) by smtp.gmail.com with ESMTPSA id w17-20020a5d6091000000b002237fd66585sm6874586wrt.92.2022.08.29.05.18.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Aug 2022 05:18:59 -0700 (PDT) Message-ID: <12759ac7-4a6c-89fa-5fd0-914728f6415e@redhat.com> Date: Mon, 29 Aug 2022 14:18:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] mm: skip reserved page for kmem leak scanning To: Zhaoyang Huang , "zhaoyang.huang" Cc: Andrew Morton , Catalin Marinas , "open list:MEMORY MANAGEMENT" , LKML , Ke Wang References: <1661483530-11308-1-git-send-email-zhaoyang.huang@unisoc.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661775543; a=rsa-sha256; cv=none; b=TAYVe1xSBubcgNhZvW8gVbGRvd/fnnhEzniNLeTrn2qTvccRZpuqMp0z8ZV5a7Jxlffx7H RWi9jMl8alaVUl8R5jKEwk7BqpaXe8RVLJZE3mlSCXucRlfgtp8CRxAT3EGo2BzEivT+rU MzcLunRJn37CvYKWU1V+04nmaWEAt7o= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cm9uOONI; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661775543; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qHsCu4PSGMMuSAfnOsJ7Dba+vX8wHbqdb2+wxTgeECc=; b=yYvGQVeT2UO+fh84VYhypFv6MIohptZZwfZ5hdZadigy4HE1Nvxgq9SpfYCk8IiyKBBBKg +G6gTrKgjIehwpNgTET1tlOTxKXEetfGQmg5uufLStYwH20RvjGnA9HvRWYT/PDMO7eyVV aY06lvjYVZL/xycEXYId4F7lmFwZoFQ= X-Rspam-User: Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cm9uOONI; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com X-Stat-Signature: j36ygihwqe7j5h3h5x4i5uc8wnw3neaq X-Rspamd-Queue-Id: 8FB8F1C003A X-Rspamd-Server: rspam02 X-HE-Tag: 1661775543-216037 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 26.08.22 05:23, Zhaoyang Huang wrote: > On Fri, Aug 26, 2022 at 11:13 AM zhaoyang.huang > wrote: >> >> From: Zhaoyang Huang >> >> It is no need to scan reserved page, skip it. >> >> Signed-off-by: Zhaoyang Huang >> --- >> mm/kmemleak.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/kmemleak.c b/mm/kmemleak.c >> index a182f5d..c546250 100644 >> --- a/mm/kmemleak.c >> +++ b/mm/kmemleak.c >> @@ -1471,7 +1471,7 @@ static void kmemleak_scan(void) >> if (page_zone(page) != zone) >> continue; >> /* only scan if page is in use */ >> - if (page_count(page) == 0) >> + if (page_count(page) == 0 || PageReserved(page)) > Sorry for previous stupid code by my faint, correct it here Did you even test the initial patch? I wonder why we should consider this change (a) I doubt it's a performance issue. If it is, please provide numbers before/after. (b) We'll stop scanning early allocations. As the memmap is usually allocated early during boot ... we'll stop scanning essentially the whole mmap and that whole loop would be dead code? What am i missing? -- Thanks, David / dhildenb