From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E1CFC001B0 for ; Mon, 24 Jul 2023 16:16:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A84F46B0071; Mon, 24 Jul 2023 12:16:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A34F88E0001; Mon, 24 Jul 2023 12:16:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FC8F6B0075; Mon, 24 Jul 2023 12:16:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 800176B0071 for ; Mon, 24 Jul 2023 12:16:13 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D4925140AFF for ; Mon, 24 Jul 2023 16:16:12 +0000 (UTC) X-FDA: 81047007384.22.2CB482D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id A7C5D4000F for ; Mon, 24 Jul 2023 16:16:09 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OZDUMoLq; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690215369; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RvPju9UecviXiaOzgyy4f97iyrnfpdgE7f1YC76j9q8=; b=59pfeTc8h8e0rftzk7yDmWeposSI5ukDwb6OsY25bRPMaHyYe7iHYdKj94N6N+eMtsOEt8 SAvx1Q2B93be+mf4RnAvnYTrvEnvu8zKhEkzm1pwMTJhgmYrSJFK2U32j3Ganv53l4bQzN ui1btOjXOfiE5i2sEQcYWCcpKtwlEwE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OZDUMoLq; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690215369; a=rsa-sha256; cv=none; b=lvhiwjS+rUCHwyYfkf2QUR0yK17WFmb3uwaa1VCgI9hFqpsqly9uArUoVuvwRsUoD7e1Pb Sv/gYR7VFZevkyT9QucWsXeaevqkMjRqfZMR7ukOk9DZVOn+8E71NuLCucUgMucdtG5lGn AbVkS198mxseY+lbHchWkFLsQa6FXmU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690215368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RvPju9UecviXiaOzgyy4f97iyrnfpdgE7f1YC76j9q8=; b=OZDUMoLqGBwoo4v4ytgoAse/gOp37ebRH1NGfn8UVKXOBVEqRUJE8+D+7vuAMY0YSWPj7R COM9zCjtENPj6PaODEJ+asekRqLbaZkyjPuDqMlymmwZ6hZLmCdos24rcDckAZ08LJhxlL vxUcxlqfFk3MBQY8K+kxbbuP3rovRzw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-61-91KBanixNt-l4k_5d6stQg-1; Mon, 24 Jul 2023 12:16:03 -0400 X-MC-Unique: 91KBanixNt-l4k_5d6stQg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6084E85A58A; Mon, 24 Jul 2023 16:16:00 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.205]) by smtp.corp.redhat.com (Postfix) with ESMTP id 766D8492C13; Mon, 24 Jul 2023 16:15:58 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230629155433.4170837-1-dhowells@redhat.com> <20230629155433.4170837-2-dhowells@redhat.com> <63041.1690191864@warthog.procyon.org.uk> To: Miklos Szeredi Cc: dhowells@redhat.com, Linus Torvalds , Matthew Wilcox , Matt Whitlock , netdev@vger.kernel.org, Dave Chinner , Jens Axboe , linux-fsdevel@kvack.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Hellwig , linux-fsdevel@vger.kernel.org Subject: Re: [RFC PATCH 1/4] splice: Fix corruption of spliced data after splice() returns MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <12728.1690215357.1@warthog.procyon.org.uk> Date: Mon, 24 Jul 2023 17:15:57 +0100 Message-ID: <12729.1690215357@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A7C5D4000F X-Stat-Signature: bd5w48om6fbh8g1qai7msjbsrpw4upnt X-HE-Tag: 1690215369-395799 X-HE-Meta: U2FsdGVkX1/PN3YjdCcTKbI7G+ixmyDJ7Vm2vOZ7Ab9ISx1iRdGO6iLfHkCqXa7H9hi/xEutwgxql+MpoPtu99V6mhLjtmkpmnlGcrN9++fkhTy01wAcIOxv/1givBTYlPxc9iqQjvQm6Umvy8a4mVij8eaAgK6NXlclNJ5hWO2fQb5yZP7Q74ip2tj7KHqTR6AsJIhKZfg2uvjrKtqYsuujmKhdBWHxQWJY6h7t8ivUkPRkNZXnutpHgYuFMqNufB5SWrpJYFwXJ+/G1gUg3Ic6GBboYGwKlMOVL5enxVAdIojpKzr156l5Kxm2aeUbDh53l4X0i+B1xp3BDOp/sWe2ZlNVDiHCKSRQLYpZSk6ydwDii1WM5xHSFBAjMoGwyAMus2sf7041vkHyVPMI/FL+M0DtRaG9nYV+04OAGFxIS18H/RDm6LUqlwr8LG3Xd7kzMLaHFCHbKRi/67ewxiqd8L0JFYITGvyJ0bdc5ErcQ88xfKUW0AoqPHeOTbuzQiz8yzoSR+dCoLug73R07suysLo4saOHDeq9NhrAZo68Kv1bBVnGnNxTFhbM5zl1jWr/aYrBKqu44hhNjnBmYNBpMMsy3TNtJlTc2RmvB3Z6naLK+YsZrtQ5yUjUomCLIvb4LBmuycZxxa1ewGgub4BY8SiKpmSslc/TyNvOj8uVeM9spMD+swcsQYrW/cSm3Q7buCfD1zaR2rBRrj/j4V3j52OymrnQ4zC5D3gHlh/Wh6tG7HZ36Tt8FhiUNYMJuqNtcEkKoyxcwmhnd8dTZxAlCrH5HrEqZY/HZqLav7vXCJiLnqLNVSCyMtnWhttxCGJG3XeEMv0V/tO/c/ZozWf80gqL6jLpSe5rwqyy1TD4C8Wc7u3ebeSpodOTqGpWDKzcA8GYE1xB2x0cXcTugadUStdLgETbY5tvUBwo+DHb131RoziJliRsZqOvHzk2StbpFt+6TjrTzA5qDq8 k0yv3nIq HDsrFwF+ngXK7NXtar8KlP+WyBBaAD+0iswas5YTyuMqlfPh+wLsidGU2VeLb0d0vIZsoDXJ2PL6ws6DUauPXKq79FGMS9cf0frtVs1/t1nJmR6Jvsx9mNStJ0wShNGUsgxpj7PWqKntlYRBOIo7Wcu+MS9bgKx0DFzvp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Miklos Szeredi wrote: > Both source and destination of copy_file_range() are regular files and Ah - the check is in generic_file_rw_checks(). Okay, nevermind. (Though it looks like it might allow this to be used with procfiles and suchlike, but anyone who tries that had probably better know what they're doing). David