From: Minchan Kim <minchan.kim@gmail.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: linux-mm@kvack.org, Joern Engel <joern@logfs.org>,
Evgeniy Polyakov <zbr@ioremap.net>
Subject: Re: why are some low-level MM routines being exported?
Date: Mon, 05 Apr 2010 00:59:44 +0900 [thread overview]
Message-ID: <1270396784.1814.92.camel@barrios-desktop> (raw)
In-Reply-To: <alpine.LFD.2.00.1004041125350.5617@localhost>
On Sun, 2010-04-04 at 11:27 -0400, Robert P. J. Day wrote:
> perusing the code in mm/filemap.c and i'm curious as to why routines
> like, for example, add_to_page_cache_lru() are being exported. is it
> really expected that loadable modules might access routines like that
> directly?
It is added by 18bc0bbd162e3 for pohmelfs and now used by logfs, too.
I didn't noticed that at that time.
With git log, any mm guys didn't add Signed-off-by or Reviewed-by.
I think it's not good for file system or module to use it directly.
It would make LRU management harder.
Is it really needed? Let's think again.
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-04-04 15:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-04 15:27 Robert P. J. Day
2010-04-04 15:59 ` Minchan Kim [this message]
2010-04-04 16:03 ` Evgeniy Polyakov
2010-04-04 16:17 ` Minchan Kim
2010-04-04 16:21 ` Minchan Kim
2010-04-04 18:15 ` Evgeniy Polyakov
2010-04-05 0:36 ` Minchan Kim
2010-04-05 12:47 ` Evgeniy Polyakov
2010-04-05 14:31 ` Minchan Kim
2010-04-04 19:55 ` Jörn Engel
2010-04-05 0:59 ` Minchan Kim
2010-04-05 5:30 ` Jörn Engel
2010-04-05 6:20 ` Minchan Kim
2010-04-05 6:22 ` Minchan Kim
2010-04-05 7:13 ` Jörn Engel
2010-04-05 8:26 ` Minchan Kim
2010-04-05 11:19 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270396784.1814.92.camel@barrios-desktop \
--to=minchan.kim@gmail.com \
--cc=joern@logfs.org \
--cc=linux-mm@kvack.org \
--cc=rpjday@crashcourse.ca \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox