From: Bob Liu <lliubbo@gmail.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, kosaki.motohiro@jp.fujitsu.com,
Bob Liu <lliubbo@gmail.com>
Subject: [PATCH] __isolate_lru_page: skip unneeded mode check
Date: Wed, 31 Mar 2010 22:10:31 +0800 [thread overview]
Message-ID: <1270044631-8576-1-git-send-email-user@bob-laptop> (raw)
From: Bob Liu <lliubbo@gmail.com>
Whether mode is ISOLATE_BOTH or not, we should compare
page_is_file_cache with argument file.
And there is no more need not when checking the active state.
Signed-off-by: Bob Liu <lliubbo@gmail.com>
---
mm/vmscan.c | 9 ++-------
1 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index e0e5f15..34d7e3d 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -862,15 +862,10 @@ int __isolate_lru_page(struct page *page, int mode, int file)
if (!PageLRU(page))
return ret;
- /*
- * When checking the active state, we need to be sure we are
- * dealing with comparible boolean values. Take the logical not
- * of each.
- */
- if (mode != ISOLATE_BOTH && (!PageActive(page) != !mode))
+ if (mode != ISOLATE_BOTH && (PageActive(page) != mode))
return ret;
- if (mode != ISOLATE_BOTH && page_is_file_cache(page) != file)
+ if (page_is_file_cache(page) != file)
return ret;
/*
--
1.5.6.3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2010-03-31 14:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-31 14:10 Bob Liu [this message]
2010-03-31 14:17 ` KOSAKI Motohiro
2010-04-01 1:30 ` Bob Liu
2010-04-01 1:39 ` KOSAKI Motohiro
2010-04-01 13:42 ` Bob Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270044631-8576-1-git-send-email-user@bob-laptop \
--to=lliubbo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox