From: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-numa@vger.kernel.org,
akpm@linux-foundation.org,
Hugh Dickins <hugh.dickins@tiscali.co.uk>,
Ravikiran Thirumalai <kiran@scalex86.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
David Rientjes <rientjes@google.com>,
eric.whitney@hp.com
Subject: Re: [PATCH 3/6] Mempolicy: rename policy_types and cleanup initialization
Date: Mon, 22 Mar 2010 12:22:59 -0400 [thread overview]
Message-ID: <1269274979.23955.25.camel@useless.americas.hpqcorp.net> (raw)
In-Reply-To: <alpine.DEB.2.00.1003220942430.15360@router.home>
On Mon, 2010-03-22 at 09:43 -0500, Christoph Lameter wrote:
> On Fri, 19 Mar 2010, Lee Schermerhorn wrote:
>
> > Rename 'policy_types[]' to 'policy_modes[]' to better match the
> > array contents.
>
> Reviewed-by: Christoph Lameter <cl@linux-foundation.org>
>
> Small nitpick: MPOL_MAX should be called MPOL_NR to follow vmstat.h and
> mmzones.h's way of naming the n+1st element.
The 'MPOL_MAX' has been there since David R [wasn't it?] created the
enum. The current name shows up in user space numaif.h from the numactl
package [2.0.3] as a #define of MPOL_MAX to MPOL_INTERLEAVE . I suppose
we could #define it to MPOL_NR to avoid the possibility of application
breakage if the enum ever makes it to the user space header. I checked
numactl sources and the only use of MPOL_MAX in the package is one of
the test programs. Don't know about end user apps out there in the
wild, tho'.
David: what do you think?
Lee
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-03-22 16:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 18:59 [PATCH 0/6] Mempolicy: additional cleanups Lee Schermerhorn
2010-03-19 18:59 ` [PATCH 1/6] Mempolicy: Don't call mpol_set_nodemask() when no_context Lee Schermerhorn
2010-03-22 14:40 ` Christoph Lameter
2010-03-22 16:11 ` Lee Schermerhorn
2010-03-19 18:59 ` [PATCH 2/6] Mempolicy: Lose unnecessary loop variable in mpol_parse_str() Lee Schermerhorn
2010-03-19 18:59 ` [PATCH 3/6] Mempolicy: rename policy_types and cleanup initialization Lee Schermerhorn
2010-03-22 14:43 ` Christoph Lameter
2010-03-22 16:22 ` Lee Schermerhorn [this message]
2010-03-19 18:59 ` [PATCH 4/6] Mempolicy: factor mpol_shared_policy_init() return paths Lee Schermerhorn
2010-03-22 14:45 ` Christoph Lameter
2010-03-19 19:00 ` [BUGFIX][PATCH 5/6] Mempolicy: fix get_mempolicy() for relative and static nodes Lee Schermerhorn
2010-03-19 19:00 ` [PATCH 6/6] Mempolicy: document cpuset interaction with tmpfs mpol mount option Lee Schermerhorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269274979.23955.25.camel@useless.americas.hpqcorp.net \
--to=lee.schermerhorn@hp.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=eric.whitney@hp.com \
--cc=hugh.dickins@tiscali.co.uk \
--cc=kiran@scalex86.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=linux-numa@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox