From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id 128086B007D for ; Wed, 17 Mar 2010 10:25:12 -0400 (EDT) Subject: Re: [PATCH 3/5] tmpfs: handle MPOL_LOCAL mount option properly From: Lee Schermerhorn In-Reply-To: <20100316145022.4C4E.A69D9226@jp.fujitsu.com> References: <201003122353.o2CNrC56015250@imap1.linux-foundation.org> <20100316143406.4C45.A69D9226@jp.fujitsu.com> <20100316145022.4C4E.A69D9226@jp.fujitsu.com> Content-Type: text/plain Date: Wed, 17 Mar 2010 10:25:08 -0400 Message-Id: <1268835908.4773.47.camel@useless.americas.hpqcorp.net> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: KOSAKI Motohiro Cc: LKML , kiran@scalex86.org, cl@linux-foundation.org, hugh.dickins@tiscali.co.uk, mel@csn.ul.ie, stable@kernel.org, linux-mm , akpm@linux-foundation.org List-ID: On Tue, 2010-03-16 at 14:51 +0900, KOSAKI Motohiro wrote: > commit 71fe804b6d5 (mempolicy: use struct mempolicy pointer in > shmem_sb_info) added mpol=local mount option. but its feature is > broken since it was born. because such code always return 1 (i.e. > mount failure). > > This patch fixes it. > > Signed-off-by: KOSAKI Motohiro > Cc: Ravikiran Thirumalai > Cc: Christoph Lameter > Cc: Mel Gorman > Cc: Lee Schermerhorn > Cc: Hugh Dickins > Cc: Acked-by: Lee Schermerhorn > --- > mm/mempolicy.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 3f77062..5c197d5 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -2212,6 +2212,7 @@ int mpol_parse_str(char *str, struct mempolicy **mpol, int no_context) > if (nodelist) > goto out; > mode = MPOL_PREFERRED; > + err = 0; > break; > case MPOL_DEFAULT: > /* -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org