From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail190.messagelabs.com (mail190.messagelabs.com [216.82.249.51]) by kanga.kvack.org (Postfix) with ESMTP id D2CAC6B004D for ; Tue, 23 Feb 2010 13:13:32 -0500 (EST) Subject: Re: [RFC PATCH -tip 2/2 v2] add a scripts for pagecache usage per process From: Peter Zijlstra In-Reply-To: <20100223175402.GE5357@nowhere> References: <4B5A3D00.8080901@bx.jp.nec.com> <4B5A3E19.6060502@bx.jp.nec.com> <1264234865.6595.75.camel@tropicana> <4B5E1855.4090809@bx.jp.nec.com> <1265012255.6526.18.camel@tropicana> <20100223175402.GE5357@nowhere> Content-Type: text/plain; charset="UTF-8" Date: Tue, 23 Feb 2010 19:13:22 +0100 Message-ID: <1266948802.11845.632.camel@laptop> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Frederic Weisbecker Cc: Tom Zanussi , Ingo Molnar , Paul Mackerras , Arnaldo Carvalho de Melo , Keiichi KII , linux-kernel@vger.kernel.org, lwoodman@redhat.com, linux-mm@kvack.org, riel@redhat.com, rostedt@goodmis.org, akpm@linux-foundation.org, Munehiro Ikeda , Atsushi Tsuji List-ID: On Tue, 2010-02-23 at 18:54 +0100, Frederic Weisbecker wrote: > > [PATCH] perf record: filter out perf process tracepoint events > > > > The perf process itself can generate a lot of trace data, which most > > of the time isn't of any interest. This patch adds a predicate to the > > kernel tracepoint filter of each recorded event type which effectively > > screens out any event generated by perf. > > > > Assuming the common case would be to ignore perf, this makes it the > > default; the old behavior can be selected by using 'perf record -P'. > > > I think filtering out perf from the instrumentation is a very > desirable features. > > But I see two drawbacks with this patch. > First of all, we want to keep perf as a part of the instrumentation > as a default behaviour I think, as it is a true part of the system > wide load. So I would rather suggest to keep it as a default and > have an exclude_perf option instead of include_perf. Agreed, excluding by default doesn't seem to be a sane idea. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org