From: Minchan Kim <minchan.kim@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Nick Piggin <npiggin@suse.de>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
David Rientjes <rientjes@google.com>
Subject: [PATCH -mm] Kill existing current task quickly
Date: Wed, 17 Feb 2010 00:59:17 +0900 [thread overview]
Message-ID: <1266335957.1709.67.camel@barrios-desktop> (raw)
I am not sure why didn't we break the loop until now.
As looking git log, I found it is removed by Nick at b78483a.
He mentioned "introduced a problem". If I miss something,
pz, correct me.
== CUT_HERE ==
[PATCH -mm] Kill existing current task quickly
If we found current task is existing but didn't set TIF_MEMDIE
during OOM victim selection, let's stop unnecessary looping for
getting high badness score task and go ahead for killing current.
This patch would make side effect skip OOM_DISABLE test.
But It's okay since the task is existing and oom_kill_process
doesn't show any killing message since __oom_kill_task will
interrupt it in oom_kill_process.
Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
Cc: Nick Piggin <npiggin@suse.de>
---
mm/oom_kill.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index 3618be3..5c21398 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -295,6 +295,7 @@ static struct task_struct
*select_bad_process(unsigned long *ppoints,
chosen = p;
*ppoints = ULONG_MAX;
+ break;
}
if (p->signal->oom_adj == OOM_DISABLE)
--
1.6.5
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2010-02-16 15:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 15:59 Minchan Kim [this message]
2010-02-16 22:03 ` David Rientjes
2010-02-17 6:26 ` Minchan Kim
2010-02-17 9:36 ` David Rientjes
2010-02-17 10:55 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266335957.1709.67.camel@barrios-desktop \
--to=minchan.kim@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox